openstack/kolla-ansible
Code Issues Proposed changes

Merge "Ensure doesn't use LOG.warn"

Browse Source
This commit is contained in:
Jenkins 2016-09-07 15:57:22 +00:00 committed by Gerrit Code Review
commit 33ace47bd3
1 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
kolla/hacking/checks.py
View File

@ -16,6 +16,19 @@ import re
mutable_default_args = re.compile(r"^\s*def .+\((.+=\{\}|.+=\[\])") mutable_default_args = re.compile(r"^\s*def .+\((.+=\{\}|.+=\[\])")
def no_log_warn(logical_line):
"""Disallow 'LOG.warn('
Deprecated LOG.warn(), instead use LOG.warning
https://bugs.launchpad.net/senlin/+bug/1508442
N352
"""
msg = ("N352: LOG.warn is deprecated, please use LOG.warning!")
if "LOG.warn(" in logical_line:
yield (0, msg)
def no_mutable_default_args(logical_line): def no_mutable_default_args(logical_line):
msg = "N301: Method's default argument shouldn't be mutable!" msg = "N301: Method's default argument shouldn't be mutable!"
if mutable_default_args.match(logical_line): if mutable_default_args.match(logical_line):
@ -24,3 +37,4 @@ def no_mutable_default_args(logical_line):
def factory(register): def factory(register):
register(no_mutable_default_args) register(no_mutable_default_args)
register(no_log_warn)