From 387de84520d247a530839a272f2f3fceb492bb7b Mon Sep 17 00:00:00 2001 From: Marcin Juszkiewicz Date: Mon, 26 Sep 2022 11:40:57 +0200 Subject: [PATCH] ansible-lint: cleanup our skip list removed: - 701 [galaxy_info missing] is no longer emited - 602 [empty string compare] is now opt-in - 208 [permissions not mentioned] is no longer emited - 106 [role name] is no longer emited renamed from number to role name: - 503 [no-handler] - 301 [no-changed-when] Change-Id: I8b059d87c94499decbd9b115ef2cde033aa88fbd --- .ansible-lint | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/.ansible-lint b/.ansible-lint index c49cf2af68..1f5a131d8c 100644 --- a/.ansible-lint +++ b/.ansible-lint @@ -1,21 +1,11 @@ --- use_default_rules: true skip_list: - # [E701] galaxy_info missing in metadata - - '701' - # [E602] https://github.com/ansible/ansible-lint/issues/457 - - '602' # [E301] Commands should not change things if nothing needs doing # TODO(mnasiadka): Fix tasks that fail this check in a later iteration - - '301' + - no-changed-when # [E503] Tasks that run when changed should likely be handlers - # TODO(mnasiadka): Rework baremetal role to do handlers instead of when: *.changed - - '503' - # [E106] Role name {} does not match ``^[a-z][a-z0-9_]+$`` pattern - - '106' - # [E208] permissions not mentioned - # FIXME(mnasiadka): Rework file/template to include permissions - - '208' + - no-handler # [unnamed-task] All tasks should be named # FIXME(mgoddard): Add names to all tasks - unnamed-task