Add validate no new line at end of file

TrivialFix

Change-Id: I817aa52caf56b7d54b266e553db6db1ceb38b773
Signed-off-by: Jeffrey Zhang <zhang.lei.fly@gmail.com>

tools/validate-all-file.py

@@ -0,0 +1,60 @@
+#!/usr/bin/python
+
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+import fnmatch
+import logging
+import os
+import re
+import sys
+
+
+PROJECT_ROOT = os.path.abspath(os.path.join(os.path.dirname(__file__), '..'))
+
+NEWLINE_EOF_INCLUDE_PATTERNS = ['*.j2', '*.yml', '*.py', '*.sh']
+NEWLINE_EOF_EXCLUDE_PATTERNS = ['.tox', '.testrepository', '.git']
+
+logging.basicConfig()
+LOG = logging.getLogger(__name__)
+
+
+def check_newline_eof():
+    includes = r'|'.join([fnmatch.translate(x)
+                          for x in NEWLINE_EOF_INCLUDE_PATTERNS])
+    excludes = r'|'.join([fnmatch.translate(x)
+                          for x in NEWLINE_EOF_EXCLUDE_PATTERNS])
+    return_code = 0
+
+    def has_newline_eof(path):
+        with open(path, 'r') as f:
+            data = f.read()
+            if data and data[-1] != '\n':
+                LOG.error('%s file error: no newline at end of file', path)
+                return False
+        return True
+
+    for root, dirs, files in os.walk(PROJECT_ROOT):
+        dirs[:] = [d for d in dirs if not re.match(excludes, d)]
+        for f in files:
+            if not re.match(excludes, f) and re.match(includes, f):
+                if not has_newline_eof(os.path.join(root, f)):
+                    return_code = 1
+    return return_code
+
+
+def main():
+    return sum([check_newline_eof()])
+
+
+if __name__ == "__main__":
+    sys.exit(main())

tox.ini

@@ -28,6 +28,7 @@ commands =
   {toxinidir}/tools/validate-all-json.sh
   {toxinidir}/tools/validate-all-yaml.sh
   {toxinidir}/tools/validate-all-dockerfiles.sh
+  {toxinidir}/tools/validate-all-file.py
 
 [testenv:bandit]
 commands = bandit -r ansible/library docker kolla tests tools