Replace always_run by check_mode

always_run is deprecated and removed in Ansible 2.4
check_mode is introduced in Ansible 2.2 and Kolla-ansible bump Ansible to
2.2.0 so it's safe to replace always_run by check_mode now.

Change-Id: Id1028d38b7bde30a6afe17b319dcdc77907914ab
Closes-Bug: #1643633
Implements: blueprint migrate-to-ansible-2-2-0

ansible/roles/ceph/tasks/bootstrap_mons.yml

@@ -2,13 +2,13 @@
 - name: Cleaning up temp file on localhost
   local_action: file path=/tmp/kolla_ceph_cluster state=absent
   changed_when: False
-  always_run: True
+  check_mode: no
   run_once: True
 
 - name: Creating temp file on localhost
   local_action: copy content=None dest=/tmp/kolla_ceph_cluster mode=0644
   changed_when: False
-  always_run: True
+  check_mode: no
   run_once: True
 
 - name: Creating ceph_mon_config volume
@@ -21,7 +21,7 @@
 - name: Writing hostname of host with existing cluster files to temp file
   local_action: copy content="{{ inventory_hostname }}" dest=/tmp/kolla_ceph_cluster mode=0644
   changed_when: False
-  always_run: True
+  check_mode: no
   when: not ceph_mon_config_volume.changed
 
 - name: Registering host from temp file
@@ -31,7 +31,7 @@
 - name: Cleaning up temp file on localhost
   local_action: file path=/tmp/kolla_ceph_cluster state=absent
   changed_when: False
-  always_run: True
+  check_mode: no
   run_once: True
 
 - include: generate_cluster.yml

ansible/roles/haproxy/tasks/precheck.yml

@@ -9,17 +9,17 @@
 - name: Clearing temp kolla_keepalived_running file
   local_action: file path=/tmp/kolla_keepalived_running state=absent
   changed_when: False
-  always_run: True
+  check_mode: no
 
 - name: Create empty temp kolla_keepalived_running file
   local_action: copy content=None dest=/tmp/kolla_keepalived_running mode=0644
   changed_when: False
-  always_run: True
+  check_mode: no
 
 - name: Getting hosts who is running keepalived
   local_action: copy content={{ ansible_hostname }} dest=/tmp/kolla_keepalived_running mode=0644
   changed_when: False
-  always_run: True
+  check_mode: no
   when:
     - inventory_hostname in groups['haproxy']
     - container_facts['keepalived'] is defined
@@ -32,7 +32,7 @@
 - name: Clearing temp kolla_keepalived_running file
   local_action: file path=/tmp/kolla_keepalived_running state=absent
   changed_when: False
-  always_run: True
+  check_mode: no
 
 - name: Checking the kolla_external_vip_interface is present
   fail: "msg='Please check the kolla_external_vip_interface property - interface {{ kolla_external_vip_interface }} not found'"

ansible/roles/mariadb/tasks/lookup_cluster.yml

@@ -2,13 +2,13 @@
 - name: Cleaning up temp file on localhost
   local_action: file path=/tmp/kolla_mariadb_cluster state=absent
   changed_when: False
-  always_run: True
+  check_mode: no
   run_once: True
 
 - name: Creating temp file on localhost
   local_action: copy content=None dest=/tmp/kolla_mariadb_cluster mode=0644
   changed_when: False
-  always_run: True
+  check_mode: no
   run_once: True
 
 - name: Creating mariadb volume
@@ -21,7 +21,7 @@
 - name: Writing hostname of host with existing cluster files to temp file
   local_action: copy content={{ ansible_hostname }} dest=/tmp/kolla_mariadb_cluster mode=0644
   changed_when: False
-  always_run: True
+  check_mode: no
   when: not mariadb_volume | changed
 
 - name: Registering host from temp file
@@ -31,5 +31,5 @@
 - name: Cleaning up temp file on localhost
   local_action: file path=/tmp/kolla_mariadb_cluster state=absent
   changed_when: False
-  always_run: True
+  check_mode: no
   run_once: True

ansible/roles/mariadb/tasks/recover_cluster.yml

@@ -17,12 +17,12 @@
 - name: Cleaning up temp file on mariadb hosts
   file: path=/tmp/kolla_mariadb_grastate.dat state=absent
   changed_when: false
-  always_run: true
+  check_mode: no
 
 - name: Cleaning up temp file on localhost
   local_action: file path=/tmp/kolla_mariadb_recover_inventory_name state=absent
   changed_when: false
-  always_run: true
+  check_mode: no
   run_once: true
 
 - block:
@@ -60,12 +60,12 @@
 - name: Cleaning up temp file on mariadb hosts
   file: path=/tmp/kolla_mariadb_grastate.dat state=absent
   changed_when: false
-  always_run: true
+  check_mode: no
 
 - name: Cleaning up temp file on localhost
   local_action: file path=/tmp/kolla_mariadb_recover_inventory_name state=absent
   changed_when: false
-  always_run: true
+  check_mode: no
   run_once: true
 
 - name: Starting first MariaDB container