openstack/kolla-ansible
Code Issues Proposed changes

Create/delete kolla_keepalived_running only once

Browse Source 
Currently, kolla_keepalived_running may be created and deleted in
parallel which causes prechecks failure. The solution is using
run_once = true.

Closes-Bug: #1714407

Change-Id: I2ec8fc2e867c87175157af8acc11f57313bfaabe
Signed-off-by: Zhijiang Hu <hu.zhijiang@zte.com.cn>
This commit is contained in:
Zhijiang Hu 2017-09-01 00:51:09 -04:00
parent 9a520e0906
commit 42e146925e
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ansible/roles/haproxy/tasks/precheck.yml
View File

@ -10,11 +10,13 @@
local_action: file path=/tmp/kolla_keepalived_running state=absent local_action: file path=/tmp/kolla_keepalived_running state=absent
changed_when: False changed_when: False
check_mode: no check_mode: no
run_once: true
- name: Create empty temp kolla_keepalived_running file - name: Create empty temp kolla_keepalived_running file
local_action: copy content=None dest=/tmp/kolla_keepalived_running mode=0644 local_action: copy content=None dest=/tmp/kolla_keepalived_running mode=0644
changed_when: False changed_when: False
check_mode: no check_mode: no
run_once: true
- name: Getting hosts who is running keepalived - name: Getting hosts who is running keepalived
local_action: copy content={{ ansible_hostname }} dest=/tmp/kolla_keepalived_running mode=0644 local_action: copy content={{ ansible_hostname }} dest=/tmp/kolla_keepalived_running mode=0644
@ -33,6 +35,7 @@
local_action: file path=/tmp/kolla_keepalived_running state=absent local_action: file path=/tmp/kolla_keepalived_running state=absent
changed_when: False changed_when: False
check_mode: no check_mode: no
run_once: true
- name: Checking the kolla_external_vip_interface is present - name: Checking the kolla_external_vip_interface is present
fail: "msg='Please check the kolla_external_vip_interface property - interface {{ kolla_external_vip_interface }} not found'" fail: "msg='Please check the kolla_external_vip_interface property - interface {{ kolla_external_vip_interface }} not found'"