Add Ansible group check to prechecks

We assume that all groups are present in the inventory, and quite obtuse
errors can result if any are not.

This change adds a precheck that checks for the presence of all expected
groups in the inventory for each service. It also introduces a common
service-precheck role that we can use for other common prechecks.

Change-Id: Ia0af1e7df4fff7f07cd6530e5b017db8fba530b3
Partially-Implements: blueprint improve-prechecks

ansible/roles/aodh/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ aodh_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/barbican/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ barbican_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/blazar/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ blazar_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/ceilometer/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ ceilometer_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Checking gnocchi backend for ceilometer
   fail:
     msg: "gnocchi is required but not enabled"

ansible/roles/chrony/tasks/precheck.yml

@@ -1,3 +1,9 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ chrony_services }}"
+    service_name: "{{ project_name }}"
+
 # TODO(Jeffrey4l), need check whether udp 123 port is used. But there is no
 # module to do this now.

ansible/roles/cinder/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ cinder_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/cloudkitty/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ cloudkitty_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/collectd/tasks/precheck.yml

@@ -1 +1,6 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ collectd_services }}"
+    service_name: "{{ project_name }}"

ansible/roles/common/tasks/precheck.yml

@@ -1 +1,6 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ common_services }}"
+    service_name: "{{ project_name }}"

ansible/roles/congress/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ congress_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/cyborg/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ cyborg_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/designate/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ designate_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/elasticsearch/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ elasticsearch_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/etcd/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ etcd_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/freezer/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ freezer_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/glance/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ glance_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/gnocchi/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ gnocchi_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/grafana/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ grafana_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/haproxy/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ haproxy_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/heat/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ heat_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/horizon/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ horizon_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/influxdb/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ influxdb_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/ironic/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ ironic_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/iscsi/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ iscsi_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/kafka/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ kafka_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/karbor/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ karbor_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/keystone/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ keystone_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/kibana/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ kibana_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/kuryr/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ kuryr_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/magnum/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ magnum_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/manila/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ manila_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/mariadb/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ mariadb_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/masakari/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ masakari_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/memcached/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ memcached_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/mistral/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ mistral_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/monasca/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ monasca_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/mongodb/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ mongodb_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/multipathd/tasks/precheck.yml

@@ -1 +1,6 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ multipathd_services }}"
+    service_name: "{{ project_name }}"

ansible/roles/murano/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ murano_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/neutron/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ neutron_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/nova-cell/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ nova_cell_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/nova/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ nova_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/octavia/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ octavia_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/openvswitch/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ openvswitch_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/ovs-dpdk/tasks/precheck.yml

@@ -1 +1,6 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ ovsdpdk_services }}"
+    service_name: "{{ project_name }}"

ansible/roles/panko/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ panko_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/placement/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ placement_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/prometheus/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ prometheus_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/qdrouterd/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ qdrouterd_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/qinling/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ qinling_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/rabbitmq/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ rabbitmq_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/rally/tasks/precheck.yml

@@ -1 +1,6 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ rally_services }}"
+    service_name: "{{ project_name }}"

ansible/roles/redis/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ redis_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/sahara/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ sahara_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/searchlight/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ searchlight_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/senlin/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ senlin_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/service-precheck/defaults/main.yml

@@ -0,0 +1,5 @@
+---
+# Common role for prechecks.
+
+# Dict of services.
+service_precheck_services: {}

ansible/roles/service-precheck/tasks/main.yml

@@ -0,0 +1,15 @@
+---
+- name: "{{ project_name }} | Validate inventory groups"
+  vars:
+    service_name: "{{ item.key }}"
+    service: "{{ item.value }}"
+  fail:
+    msg: >-
+      Ansible inventory does not contain the expected group {{ service.group }}
+      for service {{ service_name }} in {{ project_name }}.
+  loop: "{{ query('dict', service_precheck_services) }}"
+  when:
+    - "'group' in service"
+    - service.group not in groups
+  loop_control:
+    label: "{{ service_name }}"

ansible/roles/skydive/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ skydive_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/solum/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ solum_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/storm/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ storm_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/swift/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ swift_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/tacker/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ tacker_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/telegraf/tasks/precheck.yml

@@ -1 +1,6 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ telegraf_services }}"
+    service_name: "{{ project_name }}"

ansible/roles/tempest/tasks/precheck.yml

@@ -1 +1,6 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ tempest_services }}"
+    service_name: "{{ project_name }}"

ansible/roles/trove/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ trove_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/vitrage/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ vitrage_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/vmtp/tasks/precheck.yml

@@ -1 +1,6 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ vmtp_services }}"
+    service_name: "{{ project_name }}"

ansible/roles/watcher/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ watcher_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/zookeeper/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ zookeeper_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

ansible/roles/zun/tasks/precheck.yml

@@ -1,4 +1,10 @@
 ---
+- import_role:
+    name: service-precheck
+  vars:
+    service_precheck_services: "{{ zun_services }}"
+    service_name: "{{ project_name }}"
+
 - name: Get container facts
   become: true
   kolla_container_facts:

releasenotes/notes/ansible-group-precheck-fb1d1497ab92b235.yaml

@@ -0,0 +1,5 @@
+---
+features:
+  - |
+    Adds new checks to ``kolla-ansible prechecks`` that validate that expected
+    Ansible groups exist.