From 4f62dd4661ebe83a891cc69e51e88831e408bdca Mon Sep 17 00:00:00 2001 From: Michal Nasiadka Date: Wed, 20 Nov 2024 16:48:04 +0100 Subject: [PATCH] cli: Add check=True to catch Ansible failures From [1]: If check is true, and the process exits with a non-zero exit code, a CalledProcessError exception will be raised. Attributes of that exception hold the arguments, the exit code, and stdout and stderr if they were captured. [1]: https://docs.python.org/3/library/subprocess.html Closes-Bug: #2089173 Change-Id: I8cf38c2f7db1493e7303e94c212251fbeafaced3 --- kolla_ansible/utils.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kolla_ansible/utils.py b/kolla_ansible/utils.py index 3f16490483..316ba68dd6 100644 --- a/kolla_ansible/utils.py +++ b/kolla_ansible/utils.py @@ -173,6 +173,6 @@ def run_command(executable: str, if quiet: kwargs["stdout"] = subprocess.DEVNULL kwargs["stderr"] = subprocess.DEVNULL - subprocess.run(full_cmd, shell=False, **kwargs) # nosec + subprocess.run(full_cmd, check=True, shell=False, **kwargs) # nosec else: - subprocess.run(full_cmd, shell=False, **kwargs) # nosec + subprocess.run(full_cmd, check=True, shell=False, **kwargs) # nosec