openstack/kolla-ansible
Code Issues Proposed changes

host_os: Use assert on checks for readability

Browse Source 
assert will also fail when we're not meeting the conditions, makes
clear what we're actually testing, and isn't listed as a skipped task
when the condition is ok.

Change-Id: I7d316e11a733c63133cc80677ec1e790e76bf8c6
This commit is contained in:
Erik Berg 2023-01-09 18:30:23 +01:00
parent 2b88144c05
commit 50d44205a9
No known key found for this signature in database
GPG Key ID: 1182D19B0E5ED030
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
ansible/roles/prechecks/tasks/host_os_checks.yml
View File

@ -1,22 +1,22 @@
--- ---
- name: Checking host OS distribution - name: Checking host OS distribution
fail: assert:
msg: >- that: ansible_facts.distribution in host_os_distributions
fail_msg: >-
Host OS distribution {{ ansible_facts.distribution }} is not supported. Host OS distribution {{ ansible_facts.distribution }} is not supported.
Supported distributions are: {{ host_os_distributions.keys() | join(', ') }} Supported distributions are: {{ host_os_distributions.keys() | join(', ') }}
when: ansible_facts.distribution not in host_os_distributions
- name: Checking host OS release or version - name: Checking host OS release or version
fail: assert:
msg: >- that:
- ansible_facts.distribution_release in host_os_distributions[ansible_facts.distribution] or
ansible_facts.distribution_version in host_os_distributions[ansible_facts.distribution] or
ansible_facts.distribution_major_version in host_os_distributions[ansible_facts.distribution]
fail_msg: >-
{{ ansible_facts.distribution }} release {{ ansible_facts.distribution_release }} {{ ansible_facts.distribution }} release {{ ansible_facts.distribution_release }}
version {{ ansible_facts.distribution_version }} is not supported. version {{ ansible_facts.distribution_version }} is not supported.
Supported releases are: Supported releases are:
{{ host_os_distributions[ansible_facts.distribution] | join(', ') }} {{ host_os_distributions[ansible_facts.distribution] | join(', ') }}
when:
- ansible_facts.distribution_release not in host_os_distributions[ansible_facts.distribution]
- ansible_facts.distribution_version not in host_os_distributions[ansible_facts.distribution]
- ansible_facts.distribution_major_version not in host_os_distributions[ansible_facts.distribution]
- name: Checking if CentOS is Stream - name: Checking if CentOS is Stream
become: true become: true