openstack/kolla-ansible
Code Issues Proposed changes

Ansible lint: use command module instead of shell

Browse Source 
Change-Id: Ibf40216b847f103e383f19fe1ef608a75fcfd452
Co-Authored-By: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
This commit is contained in:
Mark Goddard 2020-01-13 10:44:48 +00:00
parent b0b0bd59cb
commit 5fb10e08fe
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ansible/roles/mariadb/tasks/recover_cluster.yml
View File

@ -47,7 +47,7 @@
- name: Copying MariaDB log file to /tmp - name: Copying MariaDB log file to /tmp
become: true become: true
shell: "docker cp {{ mariadb_service.container_name }}:/var/log/kolla/mariadb/mariadb.log /tmp/mariadb_tmp.log" command: "docker cp {{ mariadb_service.container_name }}:/var/log/kolla/mariadb/mariadb.log /tmp/mariadb_tmp.log"
# Look for sequence number in logs. Format is: # Look for sequence number in logs. Format is:
# WSREP: Recovered position: <UUID>:<seqno>. # WSREP: Recovered position: <UUID>:<seqno>.

2
ansible/roles/prechecks/tasks/user_checks.yml
View File

@ -12,7 +12,7 @@
# NOTE(duonghq): it's only a basic check, should be refined later # NOTE(duonghq): it's only a basic check, should be refined later
- name: Check if ansible user can do passwordless sudo - name: Check if ansible user can do passwordless sudo
shell: "true" command: "true"
become: yes become: yes
register: result register: result
failed_when: result is failed failed_when: result is failed

2
ansible/roles/rabbitmq/handlers/main.yml
View File

@ -23,7 +23,7 @@
service_name: "rabbitmq" service_name: "rabbitmq"
service: "{{ rabbitmq_services[service_name] }}" service: "{{ rabbitmq_services[service_name] }}"
become: true become: true
shell: "docker exec {{ service.container_name }} rabbitmqctl wait {{ rabbitmq_pid_file }}" command: "docker exec {{ service.container_name }} rabbitmqctl wait {{ rabbitmq_pid_file }}"
when: when:
- inventory_hostname == groups[service.group]|first - inventory_hostname == groups[service.group]|first