openstack/kolla-ansible
Code Issues Proposed changes

iscsi: Use assert on checks for readability

Browse Source 
assert will also fail when we're not meeting the conditions, makes
clear what we're actually testing, and isn't listed as a skipped task
when the condition is ok.

Change I940b1d3eceb98e16fa366c243672f588b1412d70 dropped CentOS 7,
so now we're just asserting that it's not RedHat.

Change-Id: Iec4e9a6922b67f7c9eb79f580fffbcc8160529e9
This commit is contained in:
Erik Berg 2023-01-09 19:36:46 +01:00
parent 2b88144c05
commit 73ba96e23a
No known key found for this signature in database
GPG Key ID: 1182D19B0E5ED030
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ansible/roles/iscsi/tasks/precheck.yml
View File

@ -26,9 +26,9 @@
- iscsi_services.iscsid.enabled | bool - iscsi_services.iscsid.enabled | bool
- name: Check supported platforms for tgtd - name: Check supported platforms for tgtd
fail: assert:
msg: that: ansible_facts.os_family != 'RedHat'
The SCSI target daemon tgtd is not supported on CentOS/RHEL 8 and later fail_msg: >
The SCSI target daemon tgtd is not supported on CentOS/RHEL
when: when:
- ansible_facts.os_family == 'RedHat'
- enable_tgtd | bool - enable_tgtd | bool