openstack/kolla-ansible
Code Issues Proposed changes

Stop and start container rather than use restart directly

Browse Source 
Docker has an issue[0] when restart container. But stop then start
works.

[0] https://github.com/moby/moby/issues/29704

Change-Id: If0a9c0c257cd72209be8e138a1f0b8871500e089
Closes-Bug: #1707097
This commit is contained in:
Jeffrey Zhang 2017-07-28 10:03:03 +08:00
parent 71133abce7
commit 7f2ade5b5a
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ansible/library/kolla_docker.py
View File

@ -669,7 +669,8 @@ class DockerWorker(object):
msg="No such container: {}".format(name))
else:
self.changed = True
self.dc.restart(name, timeout=graceful_timeout)
self.dc.stop(name, timeout=graceful_timeout)
self.dc.start(name)
def create_volume(self):
if not self.check_volume():

3
tests/test_kolla_docker.py
View File

@ -298,7 +298,8 @@ class TestContainer(base.BaseTestCase):
self.assertTrue(self.dw.changed)
self.dw.dc.containers.assert_called_once_with(all=True)
self.dw.dc.inspect_container.assert_called_once_with('my_container')
self.dw.dc.restart.assert_called_once_with('my_container', timeout=10)
self.dw.dc.stop.assert_called_once_with('my_container', timeout=10)
self.dw.dc.start.assert_called_once_with('my_container')
def test_restart_container_not_exists(self):
self.dw = get_DockerWorker({'name': 'fake-container',