From ed2a2704d13fa70a8dc783960d05f5469639425c Mon Sep 17 00:00:00 2001 From: Michal Arbet Date: Wed, 19 Aug 2020 17:23:18 +0200 Subject: [PATCH] Fix kolla-ansible not reflect environment changed Neutron's containers should use ENV from kolla_docker module's environment parameter (defined in roles/neutron/defaults/main.yml) after reconfigure, not only when deploying. Currently this is working only for deploy, not for reconfigure. How to test it ? - Deploy neutron with "neutron_legacy_iptables" set to yes/no. - Change value of "neutron_legacy_iptables" to opposite value as before. - Reconfigure neutron. Current result : - "KOLLA_LEGACY_IPTABLES" in container's ENV is not changed Expected result : - "KOLLA_LEGACY_IPTABLES:" in container's ENV should be changed This patch is fixing this behaviour by adding missing environment parameter to neutron's "Check neutron containers" task. Change-Id: Ibfbe2d4f49261fa766acbb6ff45da9994118bda8 Closes-Bug: #1853776 --- ansible/roles/neutron/tasks/check-containers.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/ansible/roles/neutron/tasks/check-containers.yml b/ansible/roles/neutron/tasks/check-containers.yml index c21a045ea8..12365b75e2 100644 --- a/ansible/roles/neutron/tasks/check-containers.yml +++ b/ansible/roles/neutron/tasks/check-containers.yml @@ -9,6 +9,7 @@ privileged: "{{ item.value.privileged | default(False) }}" volumes: "{{ item.value.volumes }}" dimensions: "{{ item.value.dimensions }}" + environment: "{{ item.value.environment | default(omit) }}" when: - item.value.enabled | bool - item.value.host_in_groups | bool