openstack/kolla-ansible
Code Issues Proposed changes

Fix service_mapped_to_host filter for common services

Browse Source 
In Ibecac60d1417269bbe25a280996ca9de6e6d018f, the services in the common
role were marked as being mapped to the 'all' group, since the
'service_mapped_to_host' filter expects every service definition to have
either a 'group' or 'host_in_groups' field. While this allows the filter
to pass the common services without error, it will not actually show
them as being mapped to any hosts. This is because the filter uses the
'group_names' variable, which contains all of the groups that a host
belongs to, except the default 'all' group.

This change fixes the issue by returning True from
service_mapped_to_host when the service's group is 'all'.

Change-Id: I39c8416f5d30a535c1743f9c43434b7d2a382196
Related-Bug: #1868596
This commit is contained in:
Mark Goddard 2020-04-14 14:11:14 +01:00
parent 2d8edc374d
commit 8cc58e3669
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
kolla_ansible/filters.py
View File

@ -63,7 +63,7 @@ def service_mapped_to_host(context, service):
group = service.get("group") group = service.get("group")
if group is not None: if group is not None:
return group in context.get("group_names") return group in context.get("group_names") or group == "all"
raise exception.FilterError( raise exception.FilterError(
"Service definition for '%s' does not have a 'group' or " "Service definition for '%s' does not have a 'group' or "