From 7137212ab24c032311906aa774c057b3e8929971 Mon Sep 17 00:00:00 2001 From: Michal Rostecki Date: Wed, 6 Jan 2016 20:26:44 +0100 Subject: [PATCH] Log information about successful push only if it really is The try-except-finally block in push thread was catching only ConnectionError and logging information about successful push even if some other error occured during push. TrivialFix Change-Id: I94f5ed67237d291701469a65f76146881cd67a35 --- kolla/cmd/build.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kolla/cmd/build.py b/kolla/cmd/build.py index 20fc385542..f1b362b8cf 100755 --- a/kolla/cmd/build.py +++ b/kolla/cmd/build.py @@ -83,13 +83,14 @@ class PushThread(Thread): image = self.queue.get() LOG.debug('%s:Try to push the image', image['name']) self.push_image(image) - LOG.info('%s:Pushed successfully', image['name']) except ConnectionError: LOG.exception('%s:Make sure Docker is running and that you' ' have the correct privileges to run Docker' ' (root)', image['name']) image['status'] = "connection_error" finally: + if "error" not in image['status']: + LOG.info('%s:Pushed successfully', image['name']) self.queue.task_done() def push_image(self, image):