openstack/kolla-ansible
Code Issues Proposed changes

Fix Prometheus template generation

Browse Source 
In a deployment where Prometheus is enabled and
Alertmanager is disabled the task "Copying over
prometheus config file" in
'ansible/roles/prometheus/tasks/config.yml' will
fail to template the Prometheus configuration file
'ansible/roles/prometheus/templates/prometheus.yml.j2'
as the variable 'prometheus_alert_rules' does not
contain the key 'files'. This commit fixes this bug.

Change-Id: Idbe1e52dd3693a6f168d475f9230a253dae64480
Closes-Bug: #1854540
This commit is contained in:
Scott Solkhon 2019-11-29 21:04:55 +00:00
parent baef98a232
commit 991bdc5f55
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ansible/roles/prometheus/templates/prometheus.yml.j2
View File

@ -5,7 +5,7 @@ global:
external_labels:
monitor: 'kolla'
{% if prometheus_alert_rules is defined and prometheus_alert_rules.files | length > 0 %}
{% if prometheus_alert_rules.files is defined and prometheus_alert_rules.files | length > 0 %}
rule_files:
{% for rule in prometheus_alert_rules.files %}
- "/etc/prometheus/{{ rule.path | basename }}"

8
releasenotes/notes/prometheus-config-when-alertmanager-disabled-0090c1570ff4e632.yaml Normal file
View File

@ -0,0 +1,8 @@
---
fixes:
- |
Fixes templating of Prometheus configuration when Alertmanager is disabled.
In a deployment where Prometheus is enabled and Alertmanager is disabled the
configuration for the Prometheus will fail when templating as the variable
`prometheus_alert_rules` does not contain the key `files`. For details
please see <https://bugs.launchpad.net/kolla-ansible/+bug/1854540>`__.