From c62aae6f80249b7f246a0255e7902df214634194 Mon Sep 17 00:00:00 2001
From: Paul Bourke <paul.bourke@oracle.com>
Date: Fri, 24 Feb 2017 11:59:15 +0000
Subject: [PATCH] Disable unneeded fact gathering

We explicitly gather facts for all nodes up front in the playbook, so
setup tasks for all other plays are unnecessary noise.

Change-Id: I4bc152288752da780b5cb447b4ad3f7d49390dee
---
 ansible/site.yml | 52 ++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 52 insertions(+)

diff --git a/ansible/site.yml b/ansible/site.yml
index be596a7e83..b5e05aa8b7 100644
--- a/ansible/site.yml
+++ b/ansible/site.yml
@@ -48,6 +48,7 @@
   tags: always
 
 - name: Apply role prechecks
+  gather_facts: false
   hosts:
     - all
   roles:
@@ -55,6 +56,7 @@
       when: action == "precheck"
 
 - name: Apply role chrony
+  gather_facts: false
   hosts:
     - chrony-server
     - chrony
@@ -65,6 +67,7 @@
         when: enable_chrony | bool }
 
 - name: Apply role collectd
+  gather_facts: false
   hosts: collectd
   serial: '{{ serial|default("0") }}'
   roles:
@@ -73,6 +76,7 @@
         when: enable_collectd | bool }
 
 - name: Apply role elasticsearch
+  gather_facts: false
   hosts: elasticsearch
   serial: '{{ serial|default("0") }}'
   roles:
@@ -81,6 +85,7 @@
         when: enable_elasticsearch | bool }
 
 - name: Apply role influxdb
+  gather_facts: false
   hosts: influxdb
   serial: '{{ serial|default("0") }}'
   roles:
@@ -89,6 +94,7 @@
         when: enable_influxdb | bool }
 
 - name: Apply role telegraf
+  gather_facts: false
   hosts:
     - telegraf
   serial: '{{ serial|default("0") }}'
@@ -98,6 +104,7 @@
         when: enable_telegraf | bool }
 
 - name: Apply role haproxy
+  gather_facts: false
   hosts:
     - haproxy
   roles:
@@ -106,6 +113,7 @@
         when: enable_haproxy | bool }
 
 - name: Apply role kibana
+  gather_facts: false
   hosts: kibana
   serial: '{{ serial|default("0") }}'
   roles:
@@ -114,6 +122,7 @@
         when: enable_kibana | bool }
 
 - name: Apply role memcached
+  gather_facts: false
   hosts: memcached
   serial: '{{ serial|default("0") }}'
   roles:
@@ -122,6 +131,7 @@
         when: enable_memcached | bool }
 
 - name: Apply role mariadb
+  gather_facts: false
   hosts: mariadb
   serial: '{{ serial|default("0") }}'
   roles:
@@ -130,6 +140,7 @@
         when: enable_mariadb | bool }
 
 - name: Apply role iscsi
+  gather_facts: false
   hosts:
     - iscsid
     - tgtd
@@ -140,6 +151,7 @@
         when: enable_iscsid | bool }
 
 - name: Apply role multipathd
+  gather_facts: false
   hosts:
     - multipathd
   serial: '{{ serial|default("0") }}'
@@ -149,6 +161,7 @@
         when: enable_multipathd | bool }
 
 - name: Apply role rabbitmq
+  gather_facts: false
   hosts: rabbitmq
   roles:
     - { role: rabbitmq,
@@ -156,6 +169,7 @@
         when: enable_rabbitmq | bool }
 
 - name: Apply role etcd
+  gather_facts: false
   hosts: etcd
   serial: '{{ serial|default("0") }}'
   roles:
@@ -164,6 +178,7 @@
         when: enable_etcd | bool }
 
 - name: Apply role keystone
+  gather_facts: false
   hosts: keystone
   serial: '{{ serial|default("0") }}'
   roles:
@@ -172,6 +187,7 @@
         when: enable_keystone | bool }
 
 - name: Apply role ceph
+  gather_facts: false
   hosts:
     - ceph-mon
     - ceph-osd
@@ -183,6 +199,7 @@
         when: enable_ceph | bool }
 
 - name: Apply role karbor
+  gather_facts: false
   hosts: karbor
   serial: '{{ serial|default("0") }}'
   roles:
@@ -191,6 +208,7 @@
         when: enable_karbor | bool }
 
 - name: Apply role swift
+  gather_facts: false
   hosts:
     - swift-account-server
     - swift-container-server
@@ -203,6 +221,7 @@
         when: enable_swift | bool }
 
 - name: Apply role glance
+  gather_facts: false
   hosts:
     - ceph-mon
     - glance-api
@@ -214,6 +233,7 @@
         when: enable_glance | bool }
 
 - name: Apply role ironic
+  gather_facts: false
   hosts:
     - ironic-api
     - ironic-conductor
@@ -226,6 +246,7 @@
         when: enable_ironic | bool }
 
 - name: Apply role nova
+  gather_facts: false
   hosts:
     - ceph-mon
     - compute
@@ -243,6 +264,7 @@
 # (gmmaha): Please do not change the order listed here. The current order is a
 # workaround to fix the bug https://bugs.launchpad.net/kolla/+bug/1546789
 - name: Apply role neutron
+  gather_facts: false
   hosts:
     - neutron-server
     - neutron-dhcp-agent
@@ -259,6 +281,7 @@
         when: enable_neutron | bool }
 
 - name: Apply role kuryr
+  gather_facts: false
   hosts:
     - compute
   roles:
@@ -267,6 +290,7 @@
         when: enable_kuryr | bool }
 
 - name: Apply role cinder
+  gather_facts: false
   hosts:
     - ceph-mon
     - cinder-api
@@ -280,6 +304,7 @@
         when: enable_cinder | bool }
 
 - name: Apply role heat
+  gather_facts: false
   hosts:
     - heat-api
     - heat-api-cfn
@@ -291,6 +316,7 @@
         when: enable_heat | bool }
 
 - name: Apply role horizon
+  gather_facts: false
   hosts:
     - horizon
   serial: '{{ serial|default("0") }}'
@@ -300,6 +326,7 @@
         when: enable_horizon | bool }
 
 - name: Apply role murano
+  gather_facts: false
   hosts:
     - murano-api
     - murano-engine
@@ -310,6 +337,7 @@
         when: enable_murano | bool }
 
 - name: Apply role solum
+  gather_facts: false
   hosts:
     - solum-api
     - solum-worker
@@ -322,6 +350,7 @@
         when: enable_solum | bool }
 
 - name: Apply role magnum
+  gather_facts: false
   hosts:
     - magnum-api
     - magnum-conductor
@@ -332,6 +361,7 @@
         when: enable_magnum | bool }
 
 - name: Apply role mistral
+  gather_facts: false
   hosts:
     - mistral-api
     - mistral-engine
@@ -343,6 +373,7 @@
         when: enable_mistral | bool }
 
 - name: Apply role sahara
+  gather_facts: false
   hosts:
     - sahara-api
     - sahara-engine
@@ -353,6 +384,7 @@
         when: enable_sahara | bool }
 
 - name: Apply role mongodb
+  gather_facts: false
   hosts:
     - mongodb
   serial: '{{ serial|default("0") }}'
@@ -362,6 +394,7 @@
         when: enable_mongodb | bool }
 
 - name: Apply role panko
+  gather_facts: false
   hosts: panko-api
   serial: '{{ serial|default("0") }}'
   roles:
@@ -370,6 +403,7 @@
         when: enable_panko | bool }
 
 - name: Apply role manila
+  gather_facts: false
   hosts:
     - manila-api
     - manila-data
@@ -382,6 +416,7 @@
         when: enable_manila | bool }
 
 - name: Apply role gnocchi
+  gather_facts: false
   hosts:
     - gnocchi-api
     - gnocchi-metricd
@@ -393,6 +428,7 @@
         when: enable_gnocchi | bool }
 
 - name: Apply role ceilometer
+  gather_facts: false
   hosts:
     - ceilometer
     - compute
@@ -403,6 +439,7 @@
         when: enable_ceilometer | bool }
 
 - name: Apply role aodh
+  gather_facts: false
   hosts:
     - aodh
   serial: '{{ serial|default("0") }}'
@@ -412,6 +449,7 @@
         when: enable_aodh | bool }
 
 - name: Apply role barbican
+  gather_facts: false
   hosts:
     - barbican-api
     - barbican-keystone-listener
@@ -423,6 +461,7 @@
         when: enable_barbican | bool }
 
 - name: Apply role congress
+  gather_facts: false
   hosts:
     - congress-api
     - congress-policy-engine
@@ -434,6 +473,7 @@
         when: enable_congress | bool }
 
 - name: Apply role tempest
+  gather_facts: false
   hosts:
     - tempest
   serial: '{{ serial|default("0") }}'
@@ -443,6 +483,7 @@
         when: enable_tempest | bool }
 
 - name: Apply role designate
+  gather_facts: false
   hosts:
     - designate-api
     - designate-central
@@ -456,6 +497,7 @@
         when: enable_designate | bool }
 
 - name: Apply role rally
+  gather_facts: false
   hosts: rally
   serial: '{{ serial|default("0") }}'
   roles:
@@ -464,6 +506,7 @@
         when: enable_rally | bool }
 
 - name: Apply role vmtp
+  gather_facts: false
   hosts:
     - vmtp
   serial: '{{ serial|default("0") }}'
@@ -473,6 +516,7 @@
         when: enable_vmtp | bool }
 
 - name: Apply role trove
+  gather_facts: false
   hosts:
     - trove-api
     - trove-conductor
@@ -484,6 +528,7 @@
         when: enable_trove | bool }
 
 - name: Apply role watcher
+  gather_facts: false
   hosts:
     - watcher-api
     - watcher-engine
@@ -495,6 +540,7 @@
         when: enable_watcher | bool }
 
 - name: Apply role grafana
+  gather_facts: false
   hosts:
     - grafana
   serial: '{{ serial|default("0") }}'
@@ -504,6 +550,7 @@
         when: enable_grafana | bool }
 
 - name: Apply role cloudkitty
+  gather_facts: false
   hosts:
     - cloudkitty-api
     - cloudkitty-processor
@@ -514,6 +561,7 @@
         when: enable_cloudkitty | bool }
 
 - name: Apply role freezer
+  gather_facts: false
   hosts:
     - freezer-api
   serial: '{{ serial|default("0") }}'
@@ -523,6 +571,7 @@
         when: enable_freezer | bool }
 
 - name: Apply role senlin
+  gather_facts: false
   hosts:
     - senlin-api
     - senlin-engine
@@ -533,6 +582,7 @@
         when: enable_senlin | bool }
 
 - name: Apply role searchlight
+  gather_facts: false
   hosts:
     - searchlight-api
     - searchlight-listener
@@ -543,6 +593,7 @@
         when: enable_searchlight | bool }
 
 - name: Apply role tacker
+  gather_facts: false
   hosts: tacker
   serial: '{{ serial|default("0") }}'
   roles:
@@ -551,6 +602,7 @@
         when: enable_tacker | bool }
 
 - name: Apply role octavia
+  gather_facts: false
   hosts:
     - octavia-api
     - octavia-health-manager