openstack/kolla-ansible
Code Issues Proposed changes

[tox] Fix installation of requirements

Browse Source 
Both venv and linters (and its children) environments install
kolla-ansible and thus also install the requirements.
However, they were doing this post-factum and thus without the
constraints pin.
This patch also removes the installation of test-requirements
in venv as it is meant to be used for running the software and
we already have environments for unit tests.
The doc requirements are left in place because docs mention
that ``tox -e venv -- reno`` should work. They should be harmless
but I am open to removing them as well.

Change-Id: I15f1ecc216c9ba81dad740c372d297adf279a945
This commit is contained in:
Radosław Piliszek 2022-09-29 16:37:39 +02:00
parent 4c60cc524c
commit dc9ab52d0d
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tox.ini
View File

@ -41,7 +41,7 @@ commands =
[testenv:venv] [testenv:venv]
deps = deps =
-c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master} -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}
-r{toxinidir}/test-requirements.txt -r{toxinidir}/requirements.txt
-r{toxinidir}/doc/requirements.txt -r{toxinidir}/doc/requirements.txt
commands = {posargs} commands = {posargs}
@ -93,6 +93,7 @@ setenv =
ANSIBLE_FILTER_PLUGINS = {toxinidir}/ansible/filter_plugins ANSIBLE_FILTER_PLUGINS = {toxinidir}/ansible/filter_plugins
deps = deps =
-c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master} -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}
-r{toxinidir}/requirements.txt
-r{toxinidir}/lint-requirements.txt -r{toxinidir}/lint-requirements.txt
allowlist_externals = bash allowlist_externals = bash
find find