openstack/kolla-ansible
Code Issues Proposed changes

Avoid an Ansible quirk in hacluster role

Browse Source 
Followup on I91e5c1840ace8f567daf462c4eb3ec1f0c503823

When+run_once do not play nicely. [1]
The general workaround is to use include_tasks. [2]
However, it is very unlikely user wishes to run this role
without having any pacemaker nodes so the simplification that we
use throughout the Kolla Ansible code should be enough.

[1] https://github.com/ansible/ansible/issues/11496
[2] https://github.com/ansible/ansible/issues/11496#issuecomment-412936547

Change-Id: Ifaf64e3d9d89b2ec36a883fb7458556745b64802
This commit is contained in:
Radosław Piliszek 2021-04-24 18:34:27 +00:00
parent 51134fb311
commit f3da3d8e19
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ansible/roles/hacluster/tasks/bootstrap_service.yml
View File

@ -5,9 +5,7 @@
command: docker exec {{ service.container_name }} crm_attribute --type crm_config --name stonith-enabled --update false command: docker exec {{ service.container_name }} crm_attribute --type crm_config --name stonith-enabled --update false
run_once: true run_once: true
become: true become: true
when: delegate_to: "{{ groups[service.group][0] }}"
- inventory_hostname in groups[service.group]
- service.enabled | bool
- name: Ensure remote node is added - name: Ensure remote node is added
vars: vars: