de00bf491d
Currently, we have a lot of logic for checking if a handler should run, depending on whether config files have changed and whether the container configuration has changed. As rm_work pointed out during the recent haproxy refactor, these conditionals are typically unnecessary - we can rely on Ansible's handler notification system to only trigger handlers when they need to run. This removes a lot of error prone code. This patch removes conditional handler logic for all services. It is important to ensure that we no longer trigger handlers when unnecessary, because without these checks in place it will trigger a restart of the containers. Implements: blueprint simplify-handlers Change-Id: I4f1aa03e9a9faaf8aecd556dfeafdb834042e4cd
131 lines
4.2 KiB
YAML
131 lines
4.2 KiB
YAML
---
|
|
- name: Ensuring config directories exist
|
|
file:
|
|
path: "{{ node_config_directory }}/{{ item.key }}"
|
|
state: "directory"
|
|
owner: "{{ config_owner_user }}"
|
|
group: "{{ config_owner_group }}"
|
|
mode: "0770"
|
|
become: true
|
|
when:
|
|
- inventory_hostname in groups[item.value.group]
|
|
- item.value.enabled | bool
|
|
with_dict: "{{ cloudkitty_services }}"
|
|
|
|
- name: Check if policies shall be overwritten
|
|
local_action: stat path="{{ item }}"
|
|
run_once: True
|
|
register: cloudkitty_policy
|
|
with_first_found:
|
|
- files: "{{ supported_policy_format_list }}"
|
|
paths:
|
|
- "{{ node_custom_config }}/cloudkitty/"
|
|
skip: true
|
|
|
|
- name: Set cloudkitty policy file
|
|
set_fact:
|
|
cloudkitty_policy_file: "{{ cloudkitty_policy.results.0.stat.path | basename }}"
|
|
cloudkitty_policy_file_path: "{{ cloudkitty_policy.results.0.stat.path }}"
|
|
when:
|
|
- cloudkitty_policy.results
|
|
|
|
- name: Check if custom {{ cloudkitty_custom_metrics_yaml_file }} exists
|
|
local_action: stat path="{{ node_custom_config }}/cloudkitty/{{ cloudkitty_custom_metrics_yaml_file }}"
|
|
register: cloudkitty_custom_metrics_file
|
|
|
|
- name: Copying {{ cloudkitty_custom_metrics_yaml_file }} if it exists
|
|
copy:
|
|
src: "{{ node_custom_config }}/cloudkitty/{{ cloudkitty_custom_metrics_yaml_file }}"
|
|
dest: "{{ node_config_directory }}/{{ item.key }}/{{ cloudkitty_custom_metrics_yaml_file }}"
|
|
mode: "0660"
|
|
become: true
|
|
when:
|
|
- cloudkitty_custom_metrics_file.stat.exists
|
|
- inventory_hostname in groups[item.value.group]
|
|
- item.value.enabled | bool
|
|
with_dict: "{{ cloudkitty_services }}"
|
|
notify:
|
|
- "Restart {{ item.key }} container"
|
|
|
|
- name: Are we using {{ cloudkitty_custom_metrics_yaml_file }}?
|
|
set_fact:
|
|
cloudkitty_custom_metrics_used: "{{ cloudkitty_custom_metrics_file.stat.exists }}"
|
|
|
|
- name: Copying over config.json files for services
|
|
template:
|
|
src: "{{ item.key }}.json.j2"
|
|
dest: "{{ node_config_directory }}/{{ item.key }}/config.json"
|
|
mode: "0660"
|
|
become: true
|
|
when:
|
|
- item.value.enabled | bool
|
|
- inventory_hostname in groups[item.value.group]
|
|
with_dict: "{{ cloudkitty_services }}"
|
|
notify:
|
|
- Restart {{ item.key }} container
|
|
|
|
- name: Copying over cloudkitty.conf
|
|
vars:
|
|
service_name: "{{ item.key }}"
|
|
merge_configs:
|
|
sources:
|
|
- "{{ role_path }}/templates/cloudkitty.conf.j2"
|
|
- "{{ node_custom_config }}/global.conf"
|
|
- "{{ node_custom_config }}/cloudkitty.conf"
|
|
- "{{ node_custom_config }}/cloudkitty/{{ item.key }}.conf"
|
|
- "{{ node_custom_config }}/cloudkitty/{{ inventory_hostname }}/cloudkitty.conf"
|
|
dest: "{{ node_config_directory }}/{{ item.key }}/cloudkitty.conf"
|
|
mode: "0660"
|
|
become: true
|
|
when:
|
|
- inventory_hostname in groups[item.value.group]
|
|
- item.value.enabled | bool
|
|
with_dict: "{{ cloudkitty_services }}"
|
|
notify:
|
|
- Restart {{ item.key }} container
|
|
|
|
- name: Copying over wsgi-cloudkitty.conf
|
|
vars:
|
|
service: "{{ cloudkitty_services['cloudkitty-api'] }}"
|
|
template:
|
|
src: "wsgi-cloudkitty.conf.j2"
|
|
dest: "{{ node_config_directory }}/cloudkitty-api/wsgi-cloudkitty.conf"
|
|
mode: "0660"
|
|
become: true
|
|
when:
|
|
- inventory_hostname in groups[service.group]
|
|
- service.enabled | bool
|
|
notify:
|
|
- Restart cloudkitty-api container
|
|
|
|
- name: Copying over existing policy file
|
|
template:
|
|
src: "{{ cloudkitty_policy_file_path }}"
|
|
dest: "{{ node_config_directory }}/{{ item.key }}/{{ cloudkitty_policy_file }}"
|
|
mode: "0660"
|
|
become: true
|
|
when:
|
|
- cloudkitty_policy_file is defined
|
|
- inventory_hostname in groups[item.value.group]
|
|
- item.value.enabled | bool
|
|
with_dict: "{{ cloudkitty_services }}"
|
|
notify:
|
|
- Restart {{ item.key }} container
|
|
|
|
- name: Check cloudkitty containers
|
|
become: true
|
|
kolla_docker:
|
|
action: "compare_container"
|
|
common_options: "{{ docker_common_options }}"
|
|
name: "{{ item.value.container_name }}"
|
|
image: "{{ item.value.image }}"
|
|
volumes: "{{ item.value.volumes|reject('equalto', '')|list }}"
|
|
dimensions: "{{ item.value.dimensions }}"
|
|
when:
|
|
- kolla_action != "config"
|
|
- inventory_hostname in groups[item.value.group]
|
|
- item.value.enabled | bool
|
|
with_dict: "{{ cloudkitty_services }}"
|
|
notify:
|
|
- Restart {{ item.key }} container
|