kolla-ansible/ansible/roles/ironic/tasks/bootstrap.yml
Mark Goddard b685ac44e0 Performance: replace unconditional include_tasks with import_tasks
Including tasks has a performance penalty when compared with importing
tasks. If the include has a condition associated with it, then the
overhead of the include may be lower than the overhead of skipping all
imported tasks. For unconditionally included tasks, switching to
import_tasks provides a clear benefit.

Benchmarking of include vs. import is available at [1].

This change switches from include_tasks to import_tasks where there is
no condition applied to the include.

[1] https://github.com/stackhpc/ansible-scaling/blob/master/doc/include-and-import.md#task-include-and-import

Partially-Implements: blueprint performance-improvements

Change-Id: Ia45af4a198e422773d9f009c7f7b2e32ce9e3b97
2020-08-28 16:12:03 +00:00

74 lines
2.3 KiB
YAML

---
- name: Creating Ironic database
become: true
kolla_toolbox:
module_name: mysql_db
module_args:
login_host: "{{ database_address }}"
login_port: "{{ database_port }}"
login_user: "{{ database_user }}"
login_password: "{{ database_password }}"
name: "{{ item.database_name }}"
run_once: True
delegate_to: "{{ groups[item.group][0] }}"
with_items:
- database_name: "{{ ironic_database_name }}"
group: "ironic-api"
- database_name: "{{ ironic_inspector_database_name }}"
group: "ironic-inspector"
when:
- not use_preconfigured_databases | bool
- inventory_hostname in groups[item.group]
- name: Creating Ironic database user and setting permissions
become: true
kolla_toolbox:
module_name: mysql_user
module_args:
login_host: "{{ database_address }}"
login_port: "{{ database_port }}"
login_user: "{{ database_user }}"
login_password: "{{ database_password }}"
name: "{{ item.database_user }}"
password: "{{ item.database_password }}"
host: "%"
priv: "{{ item.database_name }}.*:ALL"
append_privs: "yes"
run_once: True
delegate_to: "{{ groups[item.group][0] }}"
with_items:
- database_name: "{{ ironic_database_name }}"
database_user: "{{ ironic_database_user }}"
database_password: "{{ ironic_database_password }}"
group: "ironic-api"
- database_name: "{{ ironic_inspector_database_name }}"
database_user: "{{ ironic_inspector_database_user }}"
database_password: "{{ ironic_inspector_database_password }}"
group: "ironic-inspector"
loop_control:
label: "{{ item.database_name }}"
when:
- not use_preconfigured_databases | bool
- inventory_hostname in groups[item.group]
- import_tasks: bootstrap_service.yml
- name: Running Ironic-PXE bootstrap container
vars:
ironic_pxe: "{{ ironic_services['ironic-pxe'] }}"
become: true
kolla_docker:
action: "start_container"
common_options: "{{ docker_common_options }}"
detach: False
environment:
KOLLA_BOOTSTRAP:
KOLLA_CONFIG_STRATEGY: "{{ config_strategy }}"
image: "{{ ironic_pxe.image }}"
labels:
BOOTSTRAP:
name: "bootstrap_ironic_pxe"
restart_policy: no
volumes: "{{ ironic_pxe.volumes }}"
when: inventory_hostname in groups[ironic_pxe.group]