openstack/kolla-ansible
Code Issues Proposed changes
9834b0a37f
kolla-ansible/ansible/roles/elasticsearch/tasks
History
Mark Goddard b685ac44e0 Performance: replace unconditional include_tasks with import_tasks 
Including tasks has a performance penalty when compared with importing
tasks. If the include has a condition associated with it, then the
overhead of the include may be lower than the overhead of skipping all
imported tasks. For unconditionally included tasks, switching to
import_tasks provides a clear benefit.

Benchmarking of include vs. import is available at [1].

This change switches from include_tasks to import_tasks where there is
no condition applied to the include.

[1] https://github.com/stackhpc/ansible-scaling/blob/master/doc/include-and-import.md#task-include-and-import

Partially-Implements: blueprint performance-improvements

Change-Id: Ia45af4a198e422773d9f009c7f7b2e32ce9e3b97
2020-08-28 16:12:03 +00:00
..
check-containers.yml Support deploying Elasticsearch Curator 2019-12-09 14:49:05 +00:00
check.yml Enable sanity checks from kolla-ansible 2017-03-09 10:37:06 +00:00
config-host.yml Separate per-service host configuration tasks 2020-04-02 13:51:56 +00:00
config.yml Performance: use import_tasks for check-containers.yml 2020-07-28 12:10:59 +01:00
copy-certs.yml Refactor copy certificates task 2020-04-14 17:26:19 +00:00
deploy-containers.yml Add a job that *only* deploys updated containers 2019-09-26 17:51:14 +01:00
deploy.yml Performance: replace unconditional include_tasks with import_tasks 2020-08-28 16:12:03 +00:00
loadbalancer.yml Use "name:" instead of "role:" for *_role modules 2020-03-02 10:01:17 +01:00
main.yml Use include_tasks instead of include 2018-07-25 23:57:22 +08:00
precheck.yml Add Ansible group check to prechecks 2020-02-28 16:23:14 +00:00
pull.yml Support deploying Elasticsearch Curator 2019-12-09 14:49:05 +00:00
reconfigure.yml Performance: replace unconditional include_tasks with import_tasks 2020-08-28 16:12:03 +00:00
stop.yml Use "name:" instead of "role:" for *_role modules 2020-03-02 10:01:17 +01:00
upgrade.yml Performance: replace unconditional include_tasks with import_tasks 2020-08-28 16:12:03 +00:00