ac7c1e96e3
This fixes an issue where it is not possible to customise the `host`
config option in the Nova Compute Ironic config file without breaking
detection of the service.
This is a backwards compatible fix, which allows a user to set the
`host` config option using Ansible host or group vars.
Other reasons for not using the default host setting of
`{{ ansible_hostname }}-ironic` are covered in [1].
[1] https://specs.openstack.org/openstack/nova-specs/specs/2024.1/approved/ironic-shards.html#migrate-from-peer-list-to-shard-key.
Closes-Bug: #2056571
Change-Id: I9b562f6a5722f21b7dbec2a4d53a46a57c829155
91 lines
4.2 KiB
YAML
91 lines
4.2 KiB
YAML
---
|
|
# We need to wait for all expected compute services to register before running
|
|
# cells v2 host discovery. This includes virtualised compute services and
|
|
# ironic compute services.
|
|
# Work with --limit by including only hosts in ansible_play_batch.
|
|
|
|
- block:
|
|
- name: Waiting for nova-compute services to register themselves
|
|
become: true
|
|
command: >
|
|
{{ kolla_container_engine }} exec kolla_toolbox openstack
|
|
--os-interface {{ openstack_interface }}
|
|
--os-auth-url {{ openstack_auth.auth_url }}
|
|
--os-project-domain-name {{ openstack_auth.domain_name }}
|
|
--os-project-name {{ openstack_auth.project_name }}
|
|
--os-username {{ openstack_auth.username }}
|
|
--os-password {{ openstack_auth.password }}
|
|
--os-identity-api-version 3
|
|
--os-user-domain-name {{ openstack_auth.user_domain_name }}
|
|
--os-region-name {{ openstack_region_name }}
|
|
{% if openstack_cacert != '' %}--os-cacert {{ openstack_cacert }}{% endif %}
|
|
compute service list --format json --column Host --service nova-compute
|
|
register: nova_compute_services
|
|
changed_when: false
|
|
failed_when: false
|
|
check_mode: false
|
|
retries: 20
|
|
delay: 10
|
|
until:
|
|
- nova_compute_services is success
|
|
# A list containing the 'Host' field of compute services that have
|
|
# registered themselves. Don't exclude compute services that are disabled
|
|
# since these could have been explicitly disabled by the operator. While we
|
|
# could exclude services that are down, the nova-manage cell_v2
|
|
# discover_hosts does not do this so let's not block on it here.
|
|
- (nova_compute_services.stdout |
|
|
from_json |
|
|
map(attribute='Host') |
|
|
list)
|
|
is superset(expected_compute_service_hosts)
|
|
# Execute on one compute per cell, and delegate to a cell conductor.
|
|
when: inventory_hostname == all_computes_in_batch[0]
|
|
delegate_to: "{{ groups[nova_cell_conductor_group][0] }}"
|
|
|
|
# NOTE(mgoddard): Use a separate fail task to ensure we fail only those hosts
|
|
# that failed to register.
|
|
- name: Fail if nova-compute service failed to register
|
|
vars:
|
|
# 'Host' field of all registered compute services.
|
|
nova_compute_service_hosts: >-
|
|
{{ hostvars[all_computes_in_batch[0]].nova_compute_services.stdout |
|
|
from_json |
|
|
map(attribute='Host') |
|
|
list }}
|
|
# 'Host' field of failed compute services.
|
|
failed_compute_service_hosts: >-
|
|
{{ expected_compute_service_hosts | difference(nova_compute_service_hosts) | list }}
|
|
# Whether any compute services failed on this host.
|
|
any_failed_services: >-
|
|
{{ ansible_facts.nodename in failed_compute_service_hosts or
|
|
(ansible_facts.hostname ~ "-ironic") in failed_compute_service_hosts }}
|
|
fail:
|
|
msg: >-
|
|
The Nova compute service failed to register itself on the following
|
|
hosts: {{ failed_compute_service_hosts | join(',') }}
|
|
when: >-
|
|
any_failed_services or
|
|
(nova_compute_registration_fatal | bool and
|
|
failed_compute_service_hosts | length > 0)
|
|
vars:
|
|
# For virt, use ansible_facts.nodename rather than inventory_hostname, since this
|
|
# is similar to what nova uses internally as its default for the
|
|
# [DEFAULT] host config option.
|
|
virt_compute_service_hosts: >-
|
|
{{ virt_computes_in_batch |
|
|
map('extract', hostvars, ['ansible_facts', 'nodename']) |
|
|
list }}
|
|
# For ironic, use {{ansible_facts.hostname}}-ironic since this is what we
|
|
# configure for [DEFAULT] host in nova.conf.
|
|
ironic_compute_service_hosts: >-
|
|
{{ ironic_computes_in_batch |
|
|
map('extract', hostvars) | json_query('[].nova_compute_ironic_custom_host || [].ansible_facts.hostname') |
|
|
map('regex_replace', '^(.*)$', '\1-ironic') |
|
|
list }}
|
|
expected_compute_service_hosts: "{{ virt_compute_service_hosts + ironic_compute_service_hosts }}"
|
|
|
|
- name: Include discover_computes.yml
|
|
include_tasks: discover_computes.yml
|
|
# Execute on one compute host per cell.
|
|
when: inventory_hostname == all_computes_in_batch[0]
|