6a737b1968
Docker has no restart policy named 'never'. It has 'no'. This has bitten us already (see [1]) and might bite us again whenever we want to change the restart policy to 'no'. This patch makes our docker integration honor all valid restart policies and only valid restart policies. All relevant docker restart policy usages are patched as well. I added some FIXMEs around which are relevant to kolla-ansible docker integration. They are not fixed in here to not alter behavior. [1] https://review.opendev.org/667363 Change-Id: I1c9764fb9bbda08a71186091aced67433ad4e3d6 Signed-off-by: Radosław Piliszek <radoslaw.piliszek@gmail.com>
97 lines
2.9 KiB
YAML
97 lines
2.9 KiB
YAML
---
|
|
# NOTE: Handler order matter, init database upgrade must be before other handlers
|
|
# finish database upgrade must be the last handler.
|
|
|
|
- name: Init keystone database upgrade
|
|
vars:
|
|
service_name: "keystone"
|
|
service: "{{ keystone_services[service_name] }}"
|
|
become: true
|
|
kolla_docker:
|
|
action: "start_container"
|
|
common_options: "{{ docker_common_options }}"
|
|
detach: False
|
|
environment:
|
|
KOLLA_UPGRADE:
|
|
KOLLA_CONFIG_STRATEGY: "{{ config_strategy }}"
|
|
image: "{{ service.image }}"
|
|
labels:
|
|
KOLLA_UPGRADE:
|
|
name: "init_upgrade_database"
|
|
restart_policy: no
|
|
volumes: "{{ service.volumes|reject('equalto', '')|list }}"
|
|
dimensions: "{{ service.dimensions }}"
|
|
run_once: True
|
|
when:
|
|
- kolla_action == "upgrade"
|
|
- inventory_hostname == groups[service.group][0]
|
|
|
|
- name: Restart keystone container
|
|
vars:
|
|
service_name: "keystone"
|
|
service: "{{ keystone_services[service_name] }}"
|
|
become: true
|
|
kolla_docker:
|
|
action: "recreate_or_restart_container"
|
|
common_options: "{{ docker_common_options }}"
|
|
name: "{{ service.container_name }}"
|
|
image: "{{ service.image }}"
|
|
volumes: "{{ service.volumes|reject('equalto', '')|list }}"
|
|
dimensions: "{{ service.dimensions }}"
|
|
when:
|
|
- kolla_action != "config"
|
|
|
|
- name: Restart keystone-ssh container
|
|
vars:
|
|
service_name: "keystone-ssh"
|
|
service: "{{ keystone_services[service_name] }}"
|
|
become: true
|
|
kolla_docker:
|
|
action: "recreate_or_restart_container"
|
|
common_options: "{{ docker_common_options }}"
|
|
name: "{{ service.container_name }}"
|
|
image: "{{ service.image }}"
|
|
volumes: "{{ service.volumes|reject('equalto', '')|list }}"
|
|
dimensions: "{{ service.dimensions }}"
|
|
when:
|
|
- kolla_action != "config"
|
|
|
|
- name: Restart keystone-fernet container
|
|
vars:
|
|
service_name: "keystone-fernet"
|
|
service: "{{ keystone_services[service_name] }}"
|
|
become: true
|
|
kolla_docker:
|
|
action: "recreate_or_restart_container"
|
|
common_options: "{{ docker_common_options }}"
|
|
name: "{{ service.container_name }}"
|
|
image: "{{ service.image }}"
|
|
volumes: "{{ service.volumes|reject('equalto', '')|list }}"
|
|
dimensions: "{{ service.dimensions }}"
|
|
when:
|
|
- kolla_action != "config"
|
|
|
|
- name: Finish keystone database upgrade
|
|
vars:
|
|
service_name: "keystone"
|
|
service: "{{ keystone_services[service_name] }}"
|
|
become: true
|
|
kolla_docker:
|
|
action: "start_container"
|
|
common_options: "{{ docker_common_options }}"
|
|
detach: False
|
|
environment:
|
|
KOLLA_FINISH_UPGRADE:
|
|
KOLLA_CONFIG_STRATEGY: "{{ config_strategy }}"
|
|
image: "{{ service.image }}"
|
|
labels:
|
|
KOLLA_UPGRADE:
|
|
name: "finish_upgrade_database"
|
|
restart_policy: no
|
|
volumes: "{{ service.volumes|reject('equalto', '')|list }}"
|
|
dimensions: "{{ service.dimensions }}"
|
|
run_once: True
|
|
when:
|
|
- kolla_action == "upgrade"
|
|
- inventory_hostname == groups[service.group][-1]
|