Mark Goddard 9702d4c3c3 Performance: use import_tasks for check-containers.yml
Including tasks has a performance penalty when compared with importing
tasks. If the include has a condition associated with it, then the
overhead of the include may be lower than the overhead of skipping all
imported tasks. In the case of the check-containers.yml include, the
included file only has a single task, so the overhead of skipping this
task will not be greater than the overhead of the task import. It
therefore makes sense to switch to use import_tasks there.

Partially-Implements: blueprint performance-improvements

Change-Id: I65d911670649960708b9f6a4c110d1a7df1ad8f7
2020-07-28 12:10:59 +01:00

60 lines
2.1 KiB
YAML

---
- name: Ensuring config directories exist
file:
path: "{{ node_config_directory }}/{{ item.key }}"
state: "directory"
owner: "{{ config_owner_user }}"
group: "{{ config_owner_group }}"
mode: "0770"
when:
- item.value.enabled | bool
- item.value.host_in_groups | bool
with_dict: "{{ ovsdpdk_services }}"
- name: Copying over config.json files for services
template:
src: "{{ item.key }}.json.j2"
dest: "{{ node_config_directory }}/{{ item.key }}/config.json"
mode: "0660"
when:
- item.value.enabled | bool
- item.value.host_in_groups | bool
with_dict: "{{ ovsdpdk_services }}"
notify:
- "Restart {{ item.key }} container"
- name: Copying ovs-dpdkctl tool
copy:
src: ../tools/ovs-dpdkctl.sh
dest: "{{ node_config_directory }}/ovsdpdk-db/ovs-dpdkctl.sh"
mode: "0770"
- name: Install ovs-dpdkctl service and config
become: True
command: "{{ node_config_directory }}/ovsdpdk-db/ovs-dpdkctl.sh install"
environment:
CONFIG_FILE: "{{ node_config_directory }}/ovsdpdk-db/ovs-dpdkctl.conf"
bridge_mappings: "{{ ovs_bridge_mappings }}"
port_mappings: "{{ ovs_port_mappings }}"
cidr_mappings: "{{ ovs_cidr_mappings }}"
ovs_mem_channels: "{{ ovs_mem_channels }}"
ovs_socket_mem: "{{ ovs_socket_mem }}"
hugepage_mountpoint: "{{ ovs_hugepage_mountpoint }}"
ovs_physical_port_policy: "{{ ovs_physical_port_policy }}"
- name: Binds the interface to the target driver specifed in the config
become: True
command: "{{ node_config_directory }}/ovsdpdk-db/ovs-dpdkctl.sh bind_nics"
environment:
CONFIG_FILE: "{{ node_config_directory }}/ovsdpdk-db/ovs-dpdkctl.conf"
bridge_mappings: "{{ ovs_bridge_mappings }}"
port_mappings: "{{ ovs_port_mappings }}"
cidr_mappings: "{{ ovs_cidr_mappings }}"
ovs_mem_channels: "{{ ovs_mem_channels }}"
ovs_socket_mem: "{{ ovs_socket_mem }}"
hugepage_mountpoint: "{{ ovs_hugepage_mountpoint }}"
ovs_physical_port_policy: "{{ ovs_physical_port_policy }}"
- import_tasks: check-containers.yml
when: kolla_action != "config"