de00bf491d
Currently, we have a lot of logic for checking if a handler should run, depending on whether config files have changed and whether the container configuration has changed. As rm_work pointed out during the recent haproxy refactor, these conditionals are typically unnecessary - we can rely on Ansible's handler notification system to only trigger handlers when they need to run. This removes a lot of error prone code. This patch removes conditional handler logic for all services. It is important to ensure that we no longer trigger handlers when unnecessary, because without these checks in place it will trigger a restart of the containers. Implements: blueprint simplify-handlers Change-Id: I4f1aa03e9a9faaf8aecd556dfeafdb834042e4cd
143 lines
4.7 KiB
YAML
143 lines
4.7 KiB
YAML
---
|
|
- name: Ensuring config directories exist
|
|
become: true
|
|
file:
|
|
path: "{{ node_config_directory }}/{{ item.key }}"
|
|
state: "directory"
|
|
owner: "{{ config_owner_user }}"
|
|
group: "{{ config_owner_group }}"
|
|
mode: "0770"
|
|
when:
|
|
- inventory_hostname in groups[item.value.group]
|
|
- item.value.enabled | bool
|
|
with_dict: "{{ prometheus_services }}"
|
|
|
|
- name: Copying over config.json files
|
|
become: true
|
|
template:
|
|
src: "{{ item.key }}.json.j2"
|
|
dest: "{{ node_config_directory }}/{{ item.key }}/config.json"
|
|
mode: "0660"
|
|
when:
|
|
- inventory_hostname in groups[item.value.group]
|
|
- item.value.enabled | bool
|
|
with_dict: "{{ prometheus_services }}"
|
|
notify:
|
|
- Restart {{ item.key }} container
|
|
|
|
- name: Find custom prometheus alert rules files
|
|
become: true
|
|
local_action:
|
|
module: find
|
|
path: "{{ node_custom_config }}/prometheus/"
|
|
pattern: "*.rules"
|
|
run_once: True
|
|
register: prometheus_alert_rules
|
|
when:
|
|
- enable_prometheus_alertmanager | bool
|
|
|
|
- name: Copying over custom prometheus alert rules files
|
|
become: true
|
|
vars:
|
|
service: "{{ prometheus_services['prometheus-server']}}"
|
|
copy:
|
|
src: "{{ item.path }}"
|
|
dest: "{{ node_config_directory }}/prometheus-server/{{ item.path | basename }}"
|
|
mode: "0660"
|
|
when:
|
|
- inventory_hostname in groups[service.group]
|
|
- service.enabled | bool and enable_prometheus_alertmanager | bool
|
|
- prometheus_alert_rules is defined and prometheus_alert_rules.files | length > 0
|
|
with_items: "{{ prometheus_alert_rules.files }}"
|
|
notify:
|
|
- Restart prometheus-server container
|
|
|
|
- name: Copying over prometheus config file
|
|
become: true
|
|
vars:
|
|
service: "{{ prometheus_services['prometheus-server']}}"
|
|
template:
|
|
src: "{{ item }}"
|
|
dest: "{{ node_config_directory }}/prometheus-server/prometheus.yml"
|
|
mode: "0660"
|
|
when:
|
|
- inventory_hostname in groups[service.group]
|
|
- service.enabled | bool
|
|
with_first_found:
|
|
- "{{ node_custom_config }}/prometheus/{{ inventory_hostname }}/prometheus.yml"
|
|
- "{{ node_custom_config }}/prometheus/prometheus.yml"
|
|
- "{{ role_path }}/templates/prometheus.yml.j2"
|
|
notify:
|
|
- Restart prometheus-server container
|
|
|
|
- name: Copying over prometheus alertmanager config file
|
|
become: true
|
|
vars:
|
|
service: "{{ prometheus_services['prometheus-alertmanager']}}"
|
|
template:
|
|
src: "{{ item }}"
|
|
dest: "{{ node_config_directory }}/prometheus-alertmanager/prometheus-alertmanager.yml"
|
|
mode: "0660"
|
|
when:
|
|
- inventory_hostname in groups[service.group]
|
|
- service.enabled | bool
|
|
with_first_found:
|
|
- "{{ node_custom_config }}/prometheus/{{ inventory_hostname }}/prometheus-alertmanager.yml"
|
|
- "{{ node_custom_config }}/prometheus/prometheus-alertmanager.yml"
|
|
- "{{ role_path }}/templates/prometheus-alertmanager.yml.j2"
|
|
notify:
|
|
- Restart prometheus-alertmanager container
|
|
|
|
- name: Copying over my.cnf for mysqld_exporter
|
|
become: true
|
|
vars:
|
|
service: "{{ prometheus_services['prometheus-mysqld-exporter']}}"
|
|
merge_configs:
|
|
sources:
|
|
- "{{ node_custom_config }}/prometheus-mysqld-exporter/{{ inventory_hostname }}/my.cnf"
|
|
- "{{ node_custom_config }}/prometheus-mysqld-exporter/my.cnf"
|
|
- "{{ role_path }}/templates/my.cnf.j2"
|
|
dest: "{{ node_config_directory }}/prometheus-mysqld-exporter/my.cnf"
|
|
mode: "0660"
|
|
when:
|
|
- inventory_hostname in groups[service.group]
|
|
- service.enabled | bool
|
|
notify:
|
|
- Restart prometheus-mysqld-exporter container
|
|
|
|
- name: Copying cloud config file for openstack exporter
|
|
become: true
|
|
vars:
|
|
service: "{{ prometheus_services['prometheus-openstack-exporter'] }}"
|
|
template:
|
|
src: "{{ item }}"
|
|
dest: "{{ node_config_directory }}/prometheus-openstack-exporter/clouds.yml"
|
|
mode: "0660"
|
|
when:
|
|
- inventory_hostname in groups[service.group]
|
|
- service.enabled | bool
|
|
with_first_found:
|
|
- "{{ node_custom_config }}/prometheus-openstack-exporter/{{ inventory_hostname }}/clouds.yml"
|
|
- "{{ node_custom_config }}/prometheus-openstack-exporter/clouds.yml"
|
|
- "{{ role_path }}/templates/clouds.yml.j2"
|
|
notify:
|
|
- Restart prometheus-openstack-exporter container
|
|
|
|
- name: Check prometheus containers
|
|
become: true
|
|
kolla_docker:
|
|
action: "compare_container"
|
|
common_options: "{{ docker_common_options }}"
|
|
name: "{{ item.value.container_name }}"
|
|
image: "{{ item.value.image }}"
|
|
pid_mode: "{{ item.value.pid_mode|default('') }}"
|
|
volumes: "{{ item.value.volumes }}"
|
|
dimensions: "{{ item.value.dimensions }}"
|
|
when:
|
|
- kolla_action != "config"
|
|
- inventory_hostname in groups[item.value.group]
|
|
- item.value.enabled | bool
|
|
with_dict: "{{ prometheus_services }}"
|
|
notify:
|
|
- Restart {{ item.key }} container
|