openstack/magnum-ui
Code Issues Proposed changes

Fix tox

Browse Source 
tox4 errors if basepython and python in other envs are different. [1]

Bumped tox minversion as allowlist_externals is only supported in 3.18
[2]

[1] https://github.com/tox-dev/tox/issues/2838
[2] https://github.com/tox-dev/tox/issues/2730

Change-Id: I9d24395a7cc5d8423a58ec1e3ed8468ca6984e77
This commit is contained in:
Jake Yip 2023-02-16 22:39:12 +11:00
parent 92518c90b0
commit 452ca7da23
1 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
tox.ini
View File

@ -1,7 +1,8 @@
[tox] [tox]
envlist = pep8,eslint,karma-local,docs-local,releasenotes envlist = pep8,eslint,karma-local,docs-local,releasenotes
minversion = 2.3.2 minversion = 3.18
skipsdist = True skipsdist = True
ignore_basepython_conflict=true
[testenv] [testenv]
basepython = python3 basepython = python3
@ -55,7 +56,7 @@ commands =
{[testenv]commands} {[testenv]commands}
[testenv:eslint] [testenv:eslint]
whitelist_externals = allowlist_externals =
npm npm
commands = commands =
npm install npm install
@ -65,15 +66,15 @@ commands =
# from master branch into karma environment with python3.x for testing javascripts. # from master branch into karma environment with python3.x for testing javascripts.
# Horizon from master is needed to be cloned into ../horizon on both local and CI. # Horizon from master is needed to be cloned into ../horizon on both local and CI.
[testenv:karma] [testenv:karma]
whitelist_externals = allowlist_externals =
{[testenv:eslint]whitelist_externals} {[testenv:eslint]allowlist_externals}
commands = commands =
npm install npm install
npm run test npm run test
[testenv:karma-local] [testenv:karma-local]
whitelist_externals = allowlist_externals =
{[testenv:eslint]whitelist_externals} {[testenv:eslint]allowlist_externals}
commands = commands =
{[testenv:karma]commands} {[testenv:karma]commands}
@ -89,7 +90,7 @@ commands=
[testenv:pdf-docs] [testenv:pdf-docs]
deps = {[testenv:docs]deps} deps = {[testenv:docs]deps}
whitelist_externals = allowlist_externals =
make make
rm rm
commands = commands =
@ -109,3 +110,5 @@ deps =
{[testenv:docs]deps} {[testenv:docs]deps}
commands = commands =
sphinx-build -a -E -d releasenotes/build/doctrees -b html releasenotes/source releasenotes/build/html sphinx-build -a -E -d releasenotes/build/doctrees -b html releasenotes/source releasenotes/build/html
# dummy