openstack/magnum-ui
Code Issues Proposed changes

Add javascript tests for clusterOverviewController

Browse Source 
This patch adds javascript tests for the following modules.
 - horizon.dashboard.container-infra.clusters.details
   .overview.controller

In addition, it has changed the ".success()"  to the ".then()".

Change-Id: Ia08a22febef04b8279d658e927789eff2ce8b9cf
This commit is contained in:
Ryosuke Mizuno 2016-10-27 18:26:53 +09:00 committed by Shu Muto
parent dbbf19eb5b
commit b707291906
2 changed files with 46 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
magnum_ui/static/dashboard/container-infra/clusters/details/overview.controller.js
View File

@ -35,7 +35,7 @@
function onGetCluster(cluster) {
ctrl.cluster = cluster.data;
magnum.getClusterTemplate(ctrl.cluster.cluster_template_id).success(onGetClusterTemplate);
magnum.getClusterTemplate(ctrl.cluster.cluster_template_id).then(onGetClusterTemplate);
}
function onGetClusterTemplate(clusterTemplate) {

45
magnum_ui/static/dashboard/container-infra/clusters/details/overview.controller.spec.js Normal file
View File

@ -0,0 +1,45 @@
/**
* (c) Copyright 2016 NEC Corporation.
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may
* not use this file except in compliance with the License. You may obtain
* a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
* License for the specific language governing permissions and limitations
* under the License.
*/
(function() {
'use strict';
describe('cluster overview controller', function() {
var ctrl, magnum, deferred;
beforeEach(module('horizon.dashboard.container-infra.clusters'));
beforeEach(inject(function($controller, $q, $injector) {
magnum = $injector.get('horizon.app.core.openstack-service-api.magnum');
deferred = $q.defer();
deferred.resolve({data: {image_id: 1},items:{1:{name:1,id:1},2:{name:2,id:2}}});
spyOn(magnum, 'getClusterTemplate').and.returnValue(deferred.promise);
ctrl = $controller('ClusterOverviewController',
{
'$scope' : {context : {loadPromise: deferred.promise}}
}
);
}));
it('sets ctrl', inject(function($timeout) {
$timeout.flush();
expect(ctrl.cluster_template).toBeDefined();
expect(ctrl.cluster).toBeDefined();
}));
});
})();