openstack/octavia-dashboard
Code Issues Proposed changes

Merge "Fix popover attributes in member add dialog"

Browse Source
This commit is contained in:
Zuul 2023-07-24 08:41:51 +00:00 committed by Gerrit Code Review
commit 4e78a64391
2 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
octavia_dashboard/static/dashboard/project/lbaasv2/workflow/members/members.html
View File

@ -54,7 +54,7 @@
ng-required="true" ng-disabled="row.allocatedMember" ng-required="true" ng-disabled="row.allocatedMember"
popover-placement="top" popover-append-to-body="true" popover-placement="top" popover-append-to-body="true"
popover-trigger="focus" popover-trigger="focus"
ng-attr-popover="{$ memberDetailsForm[row.id + '-address'].$invalid && memberDetailsForm[row.id + '-address'].$dirty ? ctrl.ipError : '' $}"> uib-popover="{$ memberDetailsForm[row.id + '-address'].$invalid && memberDetailsForm[row.id + '-address'].$dirty ? ctrl.ipError : '' $}">
</div> </div>
<span ng-if="row.addresses.length === 1">{$ row.address.ip $}</span> <span ng-if="row.addresses.length === 1">{$ row.address.ip $}</span>
<div ng-if="row.addresses.length > 1" <div ng-if="row.addresses.length > 1"
@ -83,7 +83,7 @@
ng-required="true" ng-disabled="row.allocatedMember" ng-required="true" ng-disabled="row.allocatedMember"
popover-placement="top" popover-append-to-body="true" popover-placement="top" popover-append-to-body="true"
popover-trigger="focus" popover-trigger="focus"
ng-attr-popover="{$ memberDetailsForm[row.id + '-port'].$invalid && memberDetailsForm[row.id + '-port'].$dirty ? ctrl.portError : '' $}"> uib-popover="{$ memberDetailsForm[row.id + '-port'].$invalid && memberDetailsForm[row.id + '-port'].$dirty ? ctrl.portError : '' $}">
</div> </div>
</td> </td>
<td class="rsp-p1"> <td class="rsp-p1">
@ -94,7 +94,7 @@
ng-disabled="row.allocatedMember" ng-disabled="row.allocatedMember"
popover-placement="top" popover-append-to-body="true" popover-placement="top" popover-append-to-body="true"
popover-trigger="focus" popover-trigger="focus"
ng-attr-popover="{$ memberDetailsForm[row.id + '-weight'].$invalid && memberDetailsForm[row.id + '-weight'].$dirty ? ctrl.weightError : '' $}"> uib-popover="{$ memberDetailsForm[row.id + '-weight'].$invalid && memberDetailsForm[row.id + '-weight'].$dirty ? ctrl.weightError : '' $}">
</div> </div>
</td> </td>
<td class="actions_column"> <td class="actions_column">
@ -126,7 +126,7 @@
ng-disabled="row.allocatedMember" ng-disabled="row.allocatedMember"
popover-placement="top" popover-append-to-body="true" popover-placement="top" popover-append-to-body="true"
popover-trigger="focus" popover-trigger="focus"
ng-attr-popover="{$ memberDetailsForm[row.id + '-monitor-address'].$invalid && memberDetailsForm[row.id + '-monitor-address'].$dirty ? ctrl.ipError : '' $}"> uib-popover="{$ memberDetailsForm[row.id + '-monitor-address'].$invalid && memberDetailsForm[row.id + '-monitor-address'].$dirty ? ctrl.ipError : '' $}">
</dd> </dd>
</dl> </dl>
<dl class="col-lg-5 col-md-5 col-sm-5"> <dl class="col-lg-5 col-md-5 col-sm-5">
@ -138,7 +138,7 @@
ng-disabled="row.allocatedMember" ng-disabled="row.allocatedMember"
popover-placement="top" popover-append-to-body="true" popover-placement="top" popover-append-to-body="true"
popover-trigger="focus" popover-trigger="focus"
ng-attr-popover="{$ memberDetailsForm[row.id + '-monitor-port'].$invalid && memberDetailsForm[row.id + '-monitor-port'].$dirty ? ctrl.portError : '' $}"> uib-popover="{$ memberDetailsForm[row.id + '-monitor-port'].$invalid && memberDetailsForm[row.id + '-monitor-port'].$dirty ? ctrl.portError : '' $}">
</dd> </dd>
</dl> </dl>
<dl class="col-lg-5 col-md-5 col-sm-5"> <dl class="col-lg-5 col-md-5 col-sm-5">

6
releasenotes/notes/fix-chrome-member-dialog-154981a7794d5fb4.yaml Normal file
View File

@ -0,0 +1,6 @@
---
fixes:
- |
Fixed a bug when displaying the member list, some fields were not displayed
correctly and new members could not be added.
This bug affected only Google Chrome 114 and above.