openstack/openstack-ansible-os_cinder
Code Issues Proposed changes

Remove join filter from pip module tasks

Browse Source 
Ansible 2.2 now treats the 'name' argument for the pip module
as a list, removing the need for us to implement the join
filter to optimise the install execution.

Change-Id: Iad57220056af5dc3e186e7eb8aa8716424fcf463
This commit is contained in:
Jesse Pretorius 2016-11-09 21:32:24 +00:00
parent fe5f204d1e
commit 24ba34384b
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tasks/cinder_install.yml
View File

@ -30,7 +30,7 @@
- name: Install requires pip packages - name: Install requires pip packages
pip: pip:
name: "{{ cinder_requires_pip_packages | join(' ') }}" name: "{{ cinder_requires_pip_packages }}"
state: "{{ cinder_pip_package_state }}" state: "{{ cinder_pip_package_state }}"
extra_args: >- extra_args: >-
{{ (pip_install_upper_constraints is defined) | ternary('--constraint ' + pip_install_upper_constraints | default(''),'') }} {{ (pip_install_upper_constraints is defined) | ternary('--constraint ' + pip_install_upper_constraints | default(''),'') }}
@ -75,7 +75,7 @@
- name: Install pip packages - name: Install pip packages
pip: pip:
name: "{{ cinder_pip_packages | join(' ') }}" name: "{{ cinder_pip_packages }}"
state: "{{ cinder_pip_package_state }}" state: "{{ cinder_pip_package_state }}"
virtualenv: "{{ cinder_bin | dirname }}" virtualenv: "{{ cinder_bin | dirname }}"
virtualenv_site_packages: "no" virtualenv_site_packages: "no"