Rename package lists (and related vars) appropriately

In order to make it easier to differentiate between the lists of
python packages, distribution packages, downloaded packages,
package pins and other similar variables the variable names are
being changed to ensure that they have a more explicit suffix
that defines the purpose and makes the naming more consistent.

This is to facilitate a lookup plugin which will be able to look
up all the package lists and present them as a consolidated piece
of data which may be used for artifact preparation.

Change-Id: I8cc6c61ec7130e4b691481c23b9c115a2a995732

examples/playbook.yml

@@ -5,4 +5,4 @@
     - { role: "os_cinder", tags: [ "os-cinder" ] }
   vars:
     cinder_glance_api_servers: "http://glance_server:9292"
-    cinder_galera_address: "{{ internal_lb_vip_address }}"
+    cinder_galera_address: "{{ internal_lb_vip_address }}"

releasenotes/notes/package-list-name-changes-6f74fbf336030242.yaml

@@ -0,0 +1,8 @@
+---
+upgrade:
+  - The variable ``cinder_apt_packages`` has been renamed to
+    ``cinder_distro_packages``.
+  - The variable ``cinder_volume_apt_packages`` has been renamed to
+    ``cinder_volume_distro_packages``.
+  - The variable ``cinder_lvm_volume_apt_packages`` has been renamed to
+    ``cinder_lvm_volume_distro_packages``.

tasks/cinder_init_common.yml

@@ -25,4 +25,4 @@
    name: "{{ program_name }}"
    enabled: "yes"
   notify:
-    - Restart cinder services
+    - Restart cinder services

tasks/cinder_install_apt.yml

@@ -34,7 +34,7 @@
   until: install_packages|success
   retries: 5
   delay: 2
-  with_items: "{{ cinder_apt_packages }}"
+  with_items: "{{ cinder_distro_packages }}"
 
 - name: Install apt packages common between different backends
   apt:
@@ -44,7 +44,7 @@
   until: install_packages|success
   retries: 5
   delay: 2
-  with_items: "{{ cinder_volume_apt_packages }}"
+  with_items: "{{ cinder_volume_distro_packages }}"
   when:
     - inventory_hostname in groups['cinder_volume']
 
@@ -56,7 +56,7 @@
   until: install_packages|success
   retries: 5
   delay: 2
-  with_items: "{{ cinder_lvm_volume_apt_packages }}"
+  with_items: "{{ cinder_lvm_volume_distro_packages }}"
   when:
     - inventory_hostname in groups['cinder_volume']
     - cinder_backend_lvm_inuse | bool

vars/ubuntu-14.04.yml

@@ -17,7 +17,7 @@
 cache_timeout: 600
 
 # Common apt packages
-cinder_apt_packages:
+cinder_distro_packages:
   - libpq-dev
   - libkmod-dev
   - libkmod2
@@ -27,10 +27,10 @@ cinder_apt_packages:
   - zlib1g
   - zlibc
 
-cinder_volume_apt_packages:
+cinder_volume_distro_packages:
   - qemu-utils
 
-cinder_lvm_volume_apt_packages:
+cinder_lvm_volume_distro_packages:
   - dmeventd
   - parted
   - tgt

vars/ubuntu-16.04.yml

@@ -18,7 +18,7 @@
 cache_timeout: 600
 
 # Common apt packages
-cinder_apt_packages:
+cinder_distro_packages:
  - rpcbind
  - rsync
  - git
@@ -32,10 +32,10 @@ cinder_apt_packages:
  - libffi-dev
  - libssl-dev
 
-cinder_volume_apt_packages:
+cinder_volume_distro_packages:
  - qemu-utils
 
-cinder_lvm_volume_apt_packages:
+cinder_lvm_volume_distro_packages:
  - dmeventd
  - parted
  - tgt