openstack/openstack-ansible-os_horizon
Code Issues Proposed changes

Main tasks introduced without tags

Browse Source 
These tasks were introduced without a tag like -config or -install
and break the expected behavior of separating install and config:
When running only install, these tasks will run, but the register
they depend on has not run, resulting in an undefined variable.

Change-Id: I41b17bfa30750cb9c6cb6a97683f518d759474c6
This commit is contained in:
Jean-Philippe Evrard 2017-04-13 08:46:33 +00:00
parent 2112f3d9b4
commit 146ac22e75
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tasks/main.yml
View File

@ -76,6 +76,8 @@
retries: 300 retries: 300
with_items: with_items:
- "{{ async_compile_messages.results }}" - "{{ async_compile_messages.results }}"
tags:
- horizon-config
# NOTE(mhayden): The async_status check here must be done as the horizon user # NOTE(mhayden): The async_status check here must be done as the horizon user
# since the original task ran as that user. This task will fail if it is run # since the original task ran as that user. This task will fail if it is run
@ -91,6 +93,8 @@
retries: 300 retries: 300
with_items: with_items:
- "{{ async_compress_static_files.results }}" - "{{ async_compress_static_files.results }}"
tags:
- horizon-config
- include: horizon_apache.yml - include: horizon_apache.yml
tags: tags: