openstack/openstack-ansible-os_horizon
Code Issues Proposed changes

Remove join filter from pip module tasks

Browse Source 
Ansible 2.2 now treats the 'name' argument for the pip module
as a list, removing the need for us to implement the join
filter to optimise the install execution.

Change-Id: Iaae78954c0590f2d612036d2015b133f653318e5
This commit is contained in:
Jesse Pretorius 2016-11-09 21:33:23 +00:00
parent 216f85394e
commit 58c4408447
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tasks/horizon_install.yml
View File

@ -29,7 +29,7 @@
- name: Install requires pip packages - name: Install requires pip packages
pip: pip:
name: "{{ horizon_requires_pip_packages | join(' ') }}" name: "{{ horizon_requires_pip_packages }}"
state: "{{ horizon_pip_package_state }}" state: "{{ horizon_pip_package_state }}"
extra_args: >- extra_args: >-
{{ (pip_install_upper_constraints is defined) | ternary('--constraint ' + pip_install_upper_constraints | default(''),'') }} {{ (pip_install_upper_constraints is defined) | ternary('--constraint ' + pip_install_upper_constraints | default(''),'') }}
@ -74,7 +74,7 @@
- name: Install pip packages - name: Install pip packages
pip: pip:
name: "{{ horizon_pip_packages | join(' ') }}" name: "{{ horizon_pip_packages }}"
state: "{{ horizon_pip_package_state }}" state: "{{ horizon_pip_package_state }}"
virtualenv: "{{ horizon_bin | dirname }}" virtualenv: "{{ horizon_bin | dirname }}"
virtualenv_site_packages: "no" virtualenv_site_packages: "no"
@ -91,7 +91,7 @@
- name: Install optional pip packages - name: Install optional pip packages
pip: pip:
name: "{{ horizon_optional_pip_packages | join(' ') }}" name: "{{ horizon_optional_pip_packages }}"
state: "{{ horizon_pip_package_state }}" state: "{{ horizon_pip_package_state }}"
virtualenv: "{{ horizon_bin | dirname }}" virtualenv: "{{ horizon_bin | dirname }}"
virtualenv_site_packages: "no" virtualenv_site_packages: "no"