From 3a62eccb2cbb3b8071bb7b34007ee17d82eae311 Mon Sep 17 00:00:00 2001 From: Kevin Carter Date: Fri, 14 Oct 2016 16:45:32 -0500 Subject: [PATCH] Remove 'ignore_errors: true' in favor of 'failed_when: false' This change removes the use of 'ignore_errors: true' because it causes deployers to see red output and a stacktrace, which traditionally means something is broken, even when the failure is known to have a fall back option or be intentional. This conversion will provide a generally cleaner interface. It should be noted that the 'failed' filter will still function normally. Tasks with the 'failed_when: false' option will still be marked as 'failed' in any registered variable. This change simply makes the output look cleaner. Change-Id: I7067a541362c826579fc7d17abf86fe9ddc89bee Closes-Bug: #1633438 Signed-off-by: Kevin Carter --- tasks/ironic_install.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tasks/ironic_install.yml b/tasks/ironic_install.yml index 960472cd..53b054de 100644 --- a/tasks/ironic_install.yml +++ b/tasks/ironic_install.yml @@ -89,7 +89,7 @@ url: "{{ ironic_venv_download_url }}" dest: "/var/cache/{{ ironic_venv_download_url | basename }}" force: yes - ignore_errors: true + failed_when: false register: get_venv when: - not ironic_developer_mode | bool