From 7823efb09c510dd30a9b55a814cff76b52d5bdfe Mon Sep 17 00:00:00 2001 From: Jesse Pretorius Date: Wed, 4 May 2016 09:42:39 +0100 Subject: [PATCH] Change pip install task state to 'latest' Currently all pip install tasks only require the package to be present. This means that when an environment undergoes a minor upgrade the package is not upgraded to the same version that was tested with. This ultimately results in a deployed environment that does not match the tested environment. While for the services installed into venvs this is not an issue, it does affect those which do not use venvs and any packages which are installed outside of a venv or on top of a venv. This patch changes the behaviour to ensure that the install task will always use the latest available package. In developer_mode this will mean using the version specified in upper-constraints, and in an integrated build this will mean the version which is available in the wheel repo's folder for the tag. Change-Id: I75eb265b9634d7c2524d48212c9a2af2c39dc128 --- tasks/ironic_install.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tasks/ironic_install.yml b/tasks/ironic_install.yml index 250fbdca..09d60a8c 100644 --- a/tasks/ironic_install.yml +++ b/tasks/ironic_install.yml @@ -60,7 +60,7 @@ - name: Install requires pip packages pip: name: "{{ item }}" - state: present + state: latest extra_args: "{{ pip_install_options_fact }}" register: install_packages until: install_packages|success @@ -175,7 +175,7 @@ - name: Install pip packages (venv) pip: name: "{{ item }}" - state: present + state: latest virtualenv: "{{ ironic_venv_bin | dirname }}" virtualenv_site_packages: "no" extra_args: "{{ pip_install_options_fact }}" @@ -195,7 +195,7 @@ - name: Install pip packages (no venv) pip: name: "{{ item }}" - state: present + state: latest extra_args: "{{ pip_install_options_fact }}" register: install_packages until: install_packages|success