Set the user argument in the cron module

This change sets the user argument in the cron module which is
required in future versions of ansible when the cron_file argument
is also used.

Filter deprecations for skipped items have also been fixed.

Change-Id: I803cd3c62707880e873662ea86590274b2766d21
Signed-off-by: Kevin Carter <kevin.carter@rackspace.com>

tasks/keystone_credential_autorotate.yml

@@ -41,6 +41,7 @@
 - name: Remove extra auto rotation job
   cron:
     name: "Credential auto rotate job"
+    user: "{{ keystone_system_user_name }}"
     cron_file: keystone-credential-rotate
     state: "absent"
   when: >

tasks/keystone_credential_create.yml

@@ -57,7 +57,7 @@
     owner: "{{ keystone_system_user_name }}"
     group: "{{ keystone_system_group_name }}"
     mode: "0700"
-  when: not collected_existing_credential_keys | skipped
+  when: not collected_existing_credential_keys is skipped
 
 - name: Drop the existing credential keys in the master Keystone container
   copy:
@@ -66,7 +66,7 @@
     owner: "{{ keystone_system_user_name }}"
     group: "{{ keystone_system_group_name }}"
     mode: "0600"
-  when: not collected_existing_credential_keys | skipped
+  when: not collected_existing_credential_keys is skipped
   register: drop_existing_credential_keys
   with_indexed_items: "{{ collected_existing_credential_keys.results | map(attribute='content') | list | unique }}"
 
@@ -89,7 +89,7 @@
                                        --keystone-group "{{ keystone_system_group_name }}"
   become: yes
   become_user: "{{ keystone_system_user_name }}"
-  when: create_credential_keys | skipped
+  when: create_credential_keys is skipped
 
 - name: Rotate credential keys for Keystone
   command: >
@@ -98,4 +98,4 @@
                                        --keystone-group "{{ keystone_system_group_name }}"
   become: yes
   become_user: "{{ keystone_system_user_name }}"
-  when: create_credential_keys | skipped
+  when: create_credential_keys is skipped

tasks/keystone_fernet_keys_autorotate.yml

@@ -41,6 +41,7 @@
 - name: Remove extra auto rotation job
   cron:
     name: "Fernet auto rotate job"
+    user: "{{ keystone_system_user_name }}"
     cron_file: keystone-fernet-rotate
     state: "absent"
   when: >

tasks/keystone_install_source.yml

@@ -37,7 +37,6 @@
 - name: Install the python venv
   include_role:
     name: "python_venv_build"
-    private: yes
   vars:
     venv_build_distro_package_list: "{{ keystone_devel_distro_packages }}"
     venv_install_destination_path: "{{ keystone_bin | dirname }}"

tasks/keystone_uwsgi.yml

@@ -34,7 +34,6 @@
 - name: Run the systemd service role
   include_role:
     name: systemd_service
-    private: true
   vars:
     systemd_user_name: "{{ keystone_system_user_name }}"
     systemd_group_name: "{{ keystone_system_group_name }}"