Removing unneeded with_items usage for clarity

Change-Id: Ia893b793b308da076124f7b97d1e558feaa39277

tasks/keystone_apache.yml

@@ -38,11 +38,9 @@
 
 - name: Enabled keystone vhost
   file:
-    src: "{{ item.src }}"
+    src: "/etc/apache2/sites-available/keystone-httpd.conf"
-    dest: "{{ item.dest }}"
+    dest: "/etc/apache2/sites-enabled/keystone-httpd.conf"
-    state: "{{ item.state }}"
+    state: "link"
-  with_items:
-    - { src: "/etc/apache2/sites-available/keystone-httpd.conf", dest: "/etc/apache2/sites-enabled/keystone-httpd.conf", state: "link" }
   notify:
     - Restart Apache
   tags:

tasks/keystone_post_install.yml

@@ -42,13 +42,11 @@
 
 - name: Drop Keystone Configs
   copy:
-    src: "{{ item.src }}"
+    src: "sso_callback_template.html"
-    dest: "{{ item.dest }}"
+    dest: "/etc/keystone/sso_callback_template.html"
     owner: "{{ keystone_system_user_name }}"
     group: "{{ keystone_system_group_name }}"
-    mode: "{{ item.mode|default('0644') }}"
+    mode: "0644"
-  with_items:
-    - { src: "sso_callback_template.html", dest: "/etc/keystone/sso_callback_template.html" }
   notify:
     - Restart Apache
   tags:

tasks/keystone_pre_install.yml

@@ -107,13 +107,11 @@
 
 - name: Create keystone log dir
   file:
-    path: "{{ item.path }}"
+    path: "/var/log/keystone"
     state: directory
-    owner: "{{ item.owner|default(keystone_system_user_name) }}"
+    owner: "{{ keystone_system_user_name }}"
-    group: "{{ item.group|default(keystone_system_group_name) }}"
+    group: "{{ keystone_system_group_name }}"
-    mode: "{{ item.mode|default('0755') }}"
+    mode: "0755"
-  with_items:
-    - { path: "/var/log/keystone" }
   when: log_dir.rc != 0
   tags:
     - keystone-dirs