openstack/openstack-ansible-os_manila
Code Issues Proposed changes

Replace deprecated "lvm_share_export_ip" opt

Browse Source 
The config opt for manila's LVM driver:
"lvm_share_export_ip" has been deprecated in
favor of "lvm_share_export_ips" [1].

[1] Ib3594aa5d7751c829820fce830d87f6ceea6b049

Change-Id: I4e41279cd42a254fda3a200591bea2c44fecfb70
This commit is contained in:
Goutham Pacha Ravi 2019-07-30 13:53:58 -07:00
parent 0293d596bb
commit e8945f3cd5
3 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
defaults/main.yml
View File

@ -188,7 +188,7 @@ manila_quota_share_networks: 10
# share_driver: manila.share.drivers.lvm.LVMShareDriver # share_driver: manila.share.drivers.lvm.LVMShareDriver
# driver_handles_share_servers: False # driver_handles_share_servers: False
# lvm_share_volume_group: manila_shares # lvm_share_volume_group: manila_shares
# lvm_share_export_ip: <server-ip> # lvm_share_export_ips: <server-ip>
# manila_backend_lvm_inuse: True if current host has an lvm backend # manila_backend_lvm_inuse: True if current host has an lvm backend
manila_backend_lvm_inuse: "{{ (manila_backends | default('') | to_json).find('lvm') != -1 }}" manila_backend_lvm_inuse: "{{ (manila_backends | default('') | to_json).find('lvm') != -1 }}"

10
doc/source/configure-manila.rst
View File

@ -75,14 +75,14 @@ local NFS server to serve those volumes as shares.
driver_handles_share_servers: False driver_handles_share_servers: False
#. Configure the IP address or hostname of the share server. #. Configure the IP address/es or hostnames of the share server.
.. code-block:: yaml .. code-block:: yaml
lvm_share_export_ip: "IP_ADDRESS" lvm_share_export_ips: "IP_ADDRESS"
Replace ``IP_ADDRESS`` with the IP address or hostname where the Replace ``IP_ADDRESS`` with a comma separated string of one or more IP
nfs shares will be exported from. addresses or hostnames where the nfs shares will be exported from.
The following is a full configuration example of a manila LVM backend The following is a full configuration example of a manila LVM backend
named NFS_SHARE1. The manila playbooks will automatically add a custom named NFS_SHARE1. The manila playbooks will automatically add a custom
@ -100,4 +100,4 @@ named NFS_SHARE1. The manila playbooks will automatically add a custom
share_driver: manila.share.drivers.lvm.LVMShareDriver share_driver: manila.share.drivers.lvm.LVMShareDriver
driver_handles_share_servers: False driver_handles_share_servers: False
lvm_share_volume_group: manila-shares lvm_share_volume_group: manila-shares
lvm_share_export_ip: "172.29.236.100" lvm_share_export_ips: 172.29.236.100

2
tests/os_manila-overrides.yml
View File

@ -90,7 +90,7 @@ manila_backends:
share_driver: manila.share.drivers.lvm.LVMShareDriver share_driver: manila.share.drivers.lvm.LVMShareDriver
driver_handles_share_servers: False driver_handles_share_servers: False
lvm_share_volume_group: manila-shares lvm_share_volume_group: manila-shares
lvm_share_export_ip: "10.1.1.1" lvm_share_export_ips: "10.1.1.1"
filter_function: "share.size >= 0" filter_function: "share.size >= 0"
goodness_function: "share.size >= 0" goodness_function: "share.size >= 0"
generic: generic: