openstack/openstack-ansible-os_neutron
Code Issues Proposed changes

Hedge upgrade process against no software change

Browse Source 
Some deployers make use of the new role without
implementing a change in the software, resulting
in the correct local facts not being deployed.

To hedge against this, we add some more conditionals
to ensure that the facts are deployed.

Change-Id: Iae79ff4f1e0fad35a7bea70da1b8fe0e9c9b5dc7
This commit is contained in:
Jesse Pretorius 2017-07-03 12:00:10 +01:00 committed by Jesse Pretorius (odyssey4me)
parent 5a23b5bfdc
commit 25854d29b9
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
tasks/neutron_install.yml
View File

@ -142,7 +142,7 @@
delay: 2 delay: 2
notify: Restart neutron services notify: Restart neutron services
- name: Initialise the db sync local facts - name: Initialise the upgrade facts
ini_file: ini_file:
dest: "/etc/ansible/facts.d/openstack_ansible.fact" dest: "/etc/ansible/facts.d/openstack_ansible.fact"
section: neutron section: neutron
@ -153,10 +153,15 @@
state: "True" state: "True"
- name: "need_db_contract" - name: "need_db_contract"
state: "True" state: "True"
when: neutron_get_venv | changed or when: (neutron_get_venv | changed) or
neutron_venv_dir | changed or (neutron_venv_dir | changed) or
install_packages | changed or (install_packages | changed) or
install_optional_packages | changed (install_optional_packages | changed) or
(ansible_local is not defined) or
('openstack_ansible' not in ansible_local) or
('neutron' not in ansible_local['openstack_ansible']) or
('need_db_expand' not in ansible_local['openstack_ansible']['neutron']) or
('need_db_contract' not in ansible_local['openstack_ansible']['neutron'])
- name: Record the venv tag deployed - name: Record the venv tag deployed
ini_file: ini_file: