openstack/openstack-ansible-os_neutron
Code Issues Proposed changes

Resolve ansible-lint test failures

Browse Source 
With the merge of https://review.openstack.org/520177 in the
tests repo some ansible-lint failures which previously were
not being picked up are now detected.

This adds the appropriate skip tags to the tasks so that they
are not evaluated by ansible-lint.

Change-Id: I44a534b2c0bd28522d411f364da179896fc8497f
This commit is contained in:
Jesse Pretorius 2017-11-21 07:18:25 +00:00 committed by Dimitrios Markou
parent c03c932c9b
commit bb77c33a0f
2 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tests/test-calico-functional.yml
View File

@ -23,6 +23,9 @@
with_items: with_items:
- calico-felix - calico-felix
- calico-dhcp-age - calico-dhcp-age
tags:
- skip_ansible_lint
- name: Ensure that the Calico Felix agent is alive - name: Ensure that the Calico Felix agent is alive
command: openstack --os-cloud default network agent list -f json command: openstack --os-cloud default network agent list -f json
register: calico_felix_agent register: calico_felix_agent
@ -36,5 +39,8 @@
with_items: "{{ ansible_play_hosts }}" with_items: "{{ ansible_play_hosts }}"
delegate_to: "{{ groups['utility_all'][0] }}" delegate_to: "{{ groups['utility_all'][0] }}"
run_once: yes run_once: yes
tags:
- skip_ansible_lint
vars_files: vars_files:
- common/test-vars.yml - common/test-vars.yml

10
tests/test-dragonflow-functional.yml
View File

@ -31,18 +31,28 @@
python -m subunit.run discover dragonflow.tests.fullstack > /var/log/dragonflow-fullstack.subunit python -m subunit.run discover dragonflow.tests.fullstack > /var/log/dragonflow-fullstack.subunit
subunit2html /var/log/dragonflow-fullstack.subunit /var/log/dragonflow-fullstack.html subunit2html /var/log/dragonflow-fullstack.subunit /var/log/dragonflow-fullstack.html
register: dragonflow_fullstack_tests register: dragonflow_fullstack_tests
tags:
- skip_ansible_lint
- name: Ensure etc folder exists in logs - name: Ensure etc folder exists in logs
file: file:
path: /var/log/etc path: /var/log/etc
state: directory state: directory
- name: Copy config files - name: Copy config files
shell: | shell: |
cp -r /etc/neutron /var/log/etc cp -r /etc/neutron /var/log/etc
register: dragonflow_fullstack_log_copy register: dragonflow_fullstack_log_copy
tags:
- skip_ansible_lint
- name: Verify tests have passed - name: Verify tests have passed
shell: | shell: |
. {{ tempest_venv_bin }}/activate . {{ tempest_venv_bin }}/activate
subunit-filter --without {{ dragonflow_fullstack_failing_tests | join(' --without ') }} -s /var/log/dragonflow-fullstack.subunit | subunit2pyunit subunit-filter --without {{ dragonflow_fullstack_failing_tests | join(' --without ') }} -s /var/log/dragonflow-fullstack.subunit | subunit2pyunit
exit $? exit $?
tags:
- skip_ansible_lint
vars_files: vars_files:
- common/test-vars.yml - common/test-vars.yml