Fix linting issues for ansible-lint 3.4.1

Preparing this role for the ansible-lint version bump

Change-Id: I4d6689aae6a1192b595bc2f40da6d8c039373a08

defaults/main.yml

@@ -16,9 +16,10 @@
 ## Verbosity Options
 debug: False
 
-# Set the package install state for distribution packages
+# Set the package install state for distribution and pip packages
 # Options are 'present' and 'latest'
 neutron_package_state: "latest"
+neutron_pip_package_state: "latest"
 
 neutron_git_repo: https://git.openstack.org/openstack/neutron
 neutron_git_install_branch: master

tasks/calico_config.yml

@@ -16,7 +16,7 @@
 - name: Install Calico pip packages
   pip:
     name: "{{ item }}"
-    state: latest
+    state: "{{ neutron_pip_package_state }}"
     virtualenv: "{{ neutron_bin | dirname }}"
     virtualenv_site_packages: "no"
     extra_args: "{{ pip_install_options_fact }}"

tasks/main.yml

@@ -26,6 +26,7 @@
 
 - name: Check init system
   command: cat /proc/1/comm
+  changed_when: false
   register: _pid1_name
   tags:
     - always
@@ -37,7 +38,7 @@
     - always
 
 - name: Get CPU info content and store as var
-  shell: cat /proc/cpuinfo
+  command: cat /proc/cpuinfo
   register: cpuinfo_contents
   changed_when: false
   failed_when: false

tasks/neutron_init_upstart.yml

@@ -23,6 +23,5 @@
   register: upstart_init
 
 - name: Reload init scripts
-  shell: |
+  command: initctl reload-configuration
-    initctl reload-configuration
   when: upstart_init | changed

tasks/neutron_install.yml

@@ -54,7 +54,7 @@
 - name: Install requires pip packages
   pip:
     name: "{{ neutron_requires_pip_packages | join(' ') }}"
-    state: latest
+    state: "{{ neutron_pip_package_state }}"
     extra_args: "{{ pip_install_options_fact }}"
   register: install_packages
   until: install_packages|success
@@ -126,7 +126,7 @@
 - name: Install pip packages
   pip:
     name: "{{ neutron_pip_packages | join(' ') }}"
-    state: latest
+    state: "{{ neutron_pip_package_state }}"
     virtualenv: "{{ neutron_bin | dirname }}"
     virtualenv_site_packages: "no"
     extra_args: "{{ pip_install_options_fact }}"

tasks/nuage_neutron_config.yml

@@ -15,7 +15,7 @@
 - name: Install nuage neutron pip packages
   pip:
     name: "{{ neutron_proprietary_nuage_pip_packages | join(' ') }}"
-    state: latest
+    state: "{{ neutron_pip_package_state }}"
     virtualenv: "{{ neutron_bin | dirname }}"
     virtualenv_site_packages: "no"
   retries: 5