openstack/openstack-ansible-os_octavia
Code Issues Proposed changes

Do not use “-y” for package install

Browse Source 
According to "code conventions" [1], do not use "-y" option.
Instead, use apt-get install package, yum install package,
or zypper install package.

[1] https://docs.openstack.org/doc-contrib-guide/writing-style/
code-conventions.html

Change-Id: I19d120c57d8f8d1a5e9ab2259587d1978ee8fbed
This commit is contained in:
Vu Cong Tuan 2017-11-08 14:33:04 +07:00
parent 3049205570
commit 58623931f0
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
doc/source/configure-octavia.rst
View File

@ -83,7 +83,7 @@ For this process, use one of the physical hosts within the environment.
.. code-block:: bash .. code-block:: bash
apt-get install -y qemu uuid-runtime curl kpartx git jq python-pip apt-get install qemu uuid-runtime curl kpartx git jq python-pip
#. Install the necessary pip packages: #. Install the necessary pip packages:
@ -123,8 +123,8 @@ Here is a script to perform all those tasks at once:
.. code-block:: bash .. code-block:: bash
#/bin/sh #/bin/sh
apt-get install -y qemu uuid-runtime curl kpartx git jq apt-get install qemu uuid-runtime curl kpartx git jq
pip -v >/dev/null || {apt-get install -y python-pip} pip -v >/dev/null || {apt-get install python-pip}
pip install argparse Babel>=1.3 dib-utils PyYAML pip install argparse Babel>=1.3 dib-utils PyYAML
pushd /tmp pushd /tmp
git clone https://github.com/openstack/octavia.git git clone https://github.com/openstack/octavia.git