openstack/openstack-ansible-os_octavia
Code Issues Proposed changes

Remove ignore error and unnecessary when

Browse Source 
ignore error was triggered at flavor creation when octavia_all have
mutliple hosts, solved with run only on first node.

Change-Id: I92fc665ad6bd2bc4359b81bbccf1cba08e2d7703
This commit is contained in:
Kourosh Vivan 2017-10-30 16:49:05 +01:00
parent b7df5e3d0a
commit a731313a29
2 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
tasks/main.yml
View File

@ -67,6 +67,7 @@
- include: octavia_flavor_create.yml - include: octavia_flavor_create.yml
when: when:
- inventory_hostname == groups['octavia_all'][0]
- octavia_nova_flavor_uuid is not defined - octavia_nova_flavor_uuid is not defined
tags: tags:
- octavia-install - octavia-install

7
tasks/octavia_flavor_create.yml
View File

@ -29,10 +29,6 @@
vcpus: "{{ octavia_amp_vcpu }}" vcpus: "{{ octavia_amp_vcpu }}"
disk: "{{ octavia_amp_disk }}" disk: "{{ octavia_amp_disk }}"
is_public: False is_public: False
ignore_errors: yes # that module is buggy?
when:
- octavia_nova_flavor_uuid is not defined
- name: Gather Octavia Flavor Id - name: Gather Octavia Flavor Id
os_flavor_facts: os_flavor_facts:
@ -45,9 +41,6 @@
project_domain_name: "{{ octavia_service_project_domain_id }}" project_domain_name: "{{ octavia_service_project_domain_id }}"
endpoint_type: "{{ octavia_ansible_endpoint_type }}" endpoint_type: "{{ octavia_ansible_endpoint_type }}"
name: "{{ octavia_amp_flavor_name}}" name: "{{ octavia_amp_flavor_name}}"
ignore_errors: yes
when:
- octavia_nova_flavor_uuid is not defined
- name: Set Octavia Flavor UUID fact 1 - name: Set Octavia Flavor UUID fact 1
set_fact: set_fact: