1. Remove tests/test-configure-octavia.yml because the 'shade' package
does not need to be installed again - this is already done by the
role test preparation.
2. Remove the key generation as the keys are already generated in the
common tests playbook 'test-prepare-keys.yml'.
3. Add some spacing between tasks to make it more readable.
4. Implement the extra packages needed in test-requirements.txt instead
of trying to use a task to install them, because doing it in Ansible
makes understanding the venv in relation to the inventory complicated..
5. Move the vars_files argument to the top of the play to make it easier
to find and more uniform with other plays in OSA.
6. Switch from using octavia_ansible_endpoint_type to a hard-coded
endpoint, then remove the octavia_ansible_endpoint_type var.
7. Switch from using the 'endpoint_type' argument for the openstack
modules to using the more modern 'interface' argument.
8. Remove the 'run_once' argument on the 'Upload key to nova' task
because only localhost is targeted, so the argument is moot.
9. Remove the 'Set VIP fact' task in favor of just using the 'vip_output'
register in the 'Test the Listener' task. Setting a fact is pointless.
10. To help the existing patches pass, we add python-pip to the distro
packages. This will be reverted later once the required changes
to remove this requirement have merged.
Depends-On: https://review.openstack.org/589248
Change-Id: I46962090f7baf4227e838e125fd318245f2bcb85
bd9f0c0723