From 61b08b72b1e56a391b249a7dd36f0e7186937193 Mon Sep 17 00:00:00 2001 From: Jesse Pretorius Date: Tue, 2 Aug 2016 15:03:37 +0100 Subject: [PATCH] Add ability to change apt/yum package state The current method of installing the distribution packages required is set in the tasks and cannot be changed by a deployer. Currently the apt task always installs the latest package. This results in unexpected binary changes when a deployer may simply be trying to execute a configuration change. This patch adds the ability for a deployer to change the desired state so that the results are predictable. Change-Id: I1708ca8285ffa2bbd1a989b187ef3c6d9dd005c2 --- defaults/main.yml | 4 ++++ .../notes/package-state-63a870de53dd5cd8.yaml | 13 +++++++++++++ tasks/install-apt.yml | 2 +- 3 files changed, 18 insertions(+), 1 deletion(-) create mode 100644 releasenotes/notes/package-state-63a870de53dd5cd8.yaml diff --git a/defaults/main.yml b/defaults/main.yml index 08a9146..5387075 100644 --- a/defaults/main.yml +++ b/defaults/main.yml @@ -13,6 +13,10 @@ # See the License for the specific language governing permissions and # limitations under the License. +# Set the package install state for distribution packages +# Options are 'present' and 'latest' +rally_package_state: "latest" + rally_system_group_name: rally rally_system_user_name: rally rally_system_user_comment: Rally System User diff --git a/releasenotes/notes/package-state-63a870de53dd5cd8.yaml b/releasenotes/notes/package-state-63a870de53dd5cd8.yaml new file mode 100644 index 0000000..0c6741e --- /dev/null +++ b/releasenotes/notes/package-state-63a870de53dd5cd8.yaml @@ -0,0 +1,13 @@ +--- +features: + - The os_rally role now supports the ability to configure whether + apt/yum tasks install the latest available package, or just ensure + that the package is present. The default action is to ensure that + the latest package is present. The action taken may be changed to + only ensure that the package is present by setting + ``rally_package_state`` to ``present``. +upgrade: + - The os_rally role always checks whether the latest package is + installed when executed. If a deployer wishes to change the check to + only validate the presence of the package, the option + ``rally_package_state`` should be set to ``present``. diff --git a/tasks/install-apt.yml b/tasks/install-apt.yml index e5e7343..e8ade0c 100644 --- a/tasks/install-apt.yml +++ b/tasks/install-apt.yml @@ -29,7 +29,7 @@ - name: Install apt packages apt: pkg: "{{ item }}" - state: latest + state: "{{ rally_package_state }}" register: install_packages until: install_packages|success retries: 5