openstack/openstack-ansible-os_tempest
Code Issues Proposed changes

post_install: add missing onditional to workspace task

Browse Source 
The "Move over workspace when config is updated" task was running if
copy_tempest_config changed, but copy_tempest_config is created in
"Copy tempest config" only if "not tempest_use_tempestconf" conditional
is met. To avoid an error like "'copy_tempest_config' is undefined", we
need to add the same conditional to the first mentioned task.

Change-Id: I0d603dfa7319d09201f5f1d64d10cc71c56c2c21
This commit is contained in:
Emilien Macchi 2020-03-02 21:27:44 -05:00
parent 719a34a4fe
commit 2348898bc2
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tasks/tempest_post_install.yml
View File

@ -79,7 +79,9 @@
failed_when: failed_when:
- tempest_move_workspace.rc != 0 - tempest_move_workspace.rc != 0
- tempest_move_workspace.rc != 3 - tempest_move_workspace.rc != 3
when: copy_tempest_config.changed when:
- not tempest_use_tempestconf | bool
- copy_tempest_config is changed
tags: tags:
# don't trigger ANSIBLE0016 # don't trigger ANSIBLE0016
- skip_ansible_lint - skip_ansible_lint