Fix linting issues for ansible-lint 3.4.1

Preparing this role for the ansible-lint version bump

Change-Id: Icf64da0be208c33a38ea38a227c2de5c0530f2ad

defaults/main.yml

@@ -16,9 +16,10 @@
 ## Verbosity Options
 debug: False
 
-# Set the package install state for distribution packages
+# Set the package install state for distribution and pip packages
 # # Options are 'present' and 'latest'
 tempest_package_state: "latest"
+tempest_pip_package_state: "latest"
 
 # Toggle whether tempest actually executes
 tempest_run: False

tasks/tempest_install.yml

@@ -52,7 +52,7 @@
 - name: Install requires pip packages
   pip:
     name: "{{ tempest_requires_pip_packages | join(' ') }}"
-    state: latest
+    state: "{{ tempest_pip_package_state }}"
     extra_args: "{{ pip_install_options_fact }}"
   register: install_packages
   until: install_packages|success
@@ -134,7 +134,7 @@
 - name: Install pip packages
   pip:
     name: "{{ tempest_pip_packages | join(' ') }}"
-    state: latest
+    state: "{{ tempest_pip_package_state }}"
     virtualenv: "{{ tempest_venv_bin | dirname }}"
     virtualenv_site_packages: "no"
     extra_args: "{{ pip_install_options_fact }}"
@@ -172,7 +172,7 @@
 - name: Install tempest plugin requirements
   pip:
     requirements: "{{ item.stat.path }}"
-    state: latest
+    state: "{{ tempest_pip_package_state }}"
     virtualenv: "{{ tempest_venv_bin | dirname }}"
     virtualenv_site_packages: "no"
     extra_args: "{{ pip_install_options_fact }}"
@@ -186,7 +186,7 @@
 - name: Install tempest plugins
   pip:
     name: "/opt/{{ item.name|replace('-', '_') }}_{{ item.branch|replace('/', '_') }}"
-    state: latest
+    state: "{{ tempest_pip_package_state }}"
     virtualenv: "{{ tempest_venv_bin | dirname }}"
     virtualenv_site_packages: "no"
     extra_args: "{{ pip_install_options_fact }}"

tasks/tempest_post_install.yml

@@ -81,6 +81,10 @@
   args:
     chdir: "{{ tempest_venv_bin | dirname }}"
     executable: /bin/bash
+  changed_when: false
+  tags:
+    # don't trigger ANSIBLE0013
+    - skip_ansible_lint
 
 - name: Generate tempest test whitelist
   copy:

tasks/tempest_resources.yml

@@ -259,6 +259,9 @@
   failed_when: False
   changed_when: tempest1.rc != 0
   when: tempest_service_available_nova | bool
+  tags:
+    # don't trigger ANSIBLE0013
+    - skip_ansible_lint
 
 - name: Create tempest flavor 201
   shell: |
@@ -267,6 +270,10 @@
   when:
     - tempest_service_available_nova | bool
     - tempest1.rc != 0
+  tags:
+    # don't trigger ANSIBLE0013
+    - skip_ansible_lint
+
 
 - name: Check if tempest flavor 202 exists
   shell: |
@@ -276,6 +283,9 @@
   failed_when: False
   changed_when: tempest2.rc != 0
   when: tempest_service_available_nova | bool
+  tags:
+    # don't trigger ANSIBLE0013
+    - skip_ansible_lint
 
 - name: Create tempest flavor 202
   shell: |
@@ -284,3 +294,6 @@
   when:
     - tempest_service_available_nova | bool
     - tempest2.rc != 0
+  tags:
+    # don't trigger ANSIBLE0013
+    - skip_ansible_lint

tasks/tempest_run.yml

@@ -20,6 +20,10 @@
   args:
     chdir: "{{ tempest_venv_bin | dirname }}/workspace"
     executable: /bin/bash
+  changed_when: false
+  tags:
+    # don't trigger ANSIBLE0013
+    - skip_ansible_lint
 
 - name: Generate raw subunit results
   shell: |
@@ -28,6 +32,10 @@
   args:
     chdir: "{{ tempest_venv_bin | dirname }}/workspace"
     executable: /bin/bash
+  changed_when: false
+  tags:
+    # don't trigger ANSIBLE0013
+    - skip_ansible_lint
 
 - name: Generate xml subunit results
   shell: |
@@ -36,6 +44,10 @@
   args:
     chdir: "{{ tempest_venv_bin | dirname }}/workspace"
     executable: /bin/bash
+  changed_when: false
+  tags:
+    # don't trigger ANSIBLE0013
+    - skip_ansible_lint
 
 - name: Generate html subunit results
   shell: |
@@ -44,3 +56,7 @@
   args:
     chdir: "{{ tempest_venv_bin | dirname }}/workspace"
     executable: /bin/bash
+  changed_when: false
+  tags:
+    # don't trigger ANSIBLE0013
+    - skip_ansible_lint