openstack/openstack-ansible-os_trove
Code Issues Proposed changes

Fix linting issues for ansible-lint 3.4.1

Browse Source 
Preparing this role for the ansible-lint version bump

Change-Id: I37ed27a28c0551af99a1f730b2b61d0ad1db4a3b
This commit is contained in:
Logan V 2016-11-02 12:33:12 +00:00
parent ffa866d964
commit 5c954a3486
5 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
defaults/main.yml
View File

@ -15,7 +15,9 @@
# #
# (c) 2016 Donovan Francesco <donovan.francesco@is.co.za> # (c) 2016 Donovan Francesco <donovan.francesco@is.co.za>
# (c) 2016 Paul Stevens <paul.stevens@is.co.za> # (c) 2016 Paul Stevens <paul.stevens@is.co.za>
trove_package_state: "latest" trove_package_state: "latest"
trove_pip_package_state: "latest"
debug: false debug: false
trove_system_group_name: trove trove_system_group_name: trove

1
tasks/main.yml
View File

@ -29,6 +29,7 @@
- name: Check init system - name: Check init system
command: cat /proc/1/comm command: cat /proc/1/comm
changed_when: false
register: _pid1_name register: _pid1_name
tags: tags:
- always - always

1
tasks/trove_db_setup.yml
View File

@ -22,3 +22,4 @@
db_sync {{ trove_db_sync_options }} db_sync {{ trove_db_sync_options }}
become: yes become: yes
become_user: "{{ trove_system_user_name }}" become_user: "{{ trove_system_user_name }}"
changed_when: false

3
tasks/trove_init_upstart.yml
View File

@ -30,8 +30,7 @@
- Restart Apache - Restart Apache
- name: Reload init scripts - name: Reload init scripts
shell: | command: initctl reload-configuration
initctl reload-configuration
when: upstart_init | changed when: upstart_init | changed
notify: notify:
- Restart trove API services - Restart trove API services

4
tasks/trove_install.yml
View File

@ -55,7 +55,7 @@
- name: Install required pip packages - name: Install required pip packages
pip: pip:
name: "{{ trove_requires_pip_packages | join(' ') }}" name: "{{ trove_requires_pip_packages | join(' ') }}"
state: latest state: "{{ trove_pip_package_state }}"
extra_args: "{{ pip_install_options_fact }}" extra_args: "{{ pip_install_options_fact }}"
register: install_packages register: install_packages
until: install_packages|success until: install_packages|success
@ -129,7 +129,7 @@
- name: Install pip packages - name: Install pip packages
pip: pip:
name: "{{ trove_pip_packages | join(' ') }}" name: "{{ trove_pip_packages | join(' ') }}"
state: latest state: "{{ trove_pip_package_state }}"
virtualenv: "{{ trove_bin | dirname }}" virtualenv: "{{ trove_bin | dirname }}"
virtualenv_site_packages: "no" virtualenv_site_packages: "no"
extra_args: "{{ pip_install_options_fact }}" extra_args: "{{ pip_install_options_fact }}"