openstack/openstack-ansible
Code Issues Proposed changes

Ceph-RGW HAProxy config skipped when shouldnt

Browse Source 
Now that group ceph-rgw is in the default inventory (commit c700fdba)
the logic for haproxy_backend_nodes would always select the group
'ceph-rgw' as it will always be defined, regardless of length.

If using the ceph_rgws variable instead of the ceph-rgws group it
meant that the haproxy_backend_nodes equated to an empty group.
So the 'when' criteria in haproxy_service_config.yml did not get met
and the services config was not provisioned.

This fix checks the length of the ceph-rgws group.
If its not greater than zero, haproxy_backend_nodes is defaulted
back to ceph_rgws.

Change-Id: I7ac3e3ba9e64b38ec22704394fcd5f402dd9d7f8
This commit is contained in:
Georgina Shippey 2019-08-14 16:16:21 +01:00
parent 95d4b5b04a
commit 00417b6856
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
inventory/group_vars/haproxy/haproxy.yml
View File

@ -363,7 +363,7 @@ haproxy_default_services:
haproxy_service_enabled: "{{ neutron_plugin_type == 'ml2.opendaylight' }}"
- service:
haproxy_service_name: ceph-rgw
haproxy_backend_nodes: "{{ groups['ceph-rgw'] | default(ceph_rgws) }}"
haproxy_backend_nodes: "{{ (groups['ceph-rgw'] is defined and groups['ceph-rgw'] | length > 0) | ternary(groups['ceph-rgw'], ceph_rgws) }}"
haproxy_ssl: "{{ haproxy_ssl }}"
haproxy_balance_alg: source
haproxy_port: "{{ radosgw_service_port | default(7980) }}"