Properly apply always tag to install_defaults

In order to complete a playbook successfully we rely on having
deploy-type specific variables, which are provided by install_defaults
role.

This used to be a simple include_vars statement instead, which was
always executed with any tags, but it's not a case now with inlcude_role
where we should explicitly take care about always running the role
regardless of tags provided.

Change-Id: I7a7112dd6a7c3a360dc6c0d206a855c220a027a6

playbooks/ceph-install.yml

@@ -29,6 +29,11 @@
         name: openstack.osa.install_defaults
         defaults_from: "{{ install_method }}"
         public: true
+        apply:
+          tags:
+            - always
+      tags:
+        - always
 
     - name: Gather additional facts for monitor_address_block
       include_tasks: "common-tasks/gather-hardware-facts.yml"
@@ -140,6 +145,11 @@
         name: openstack.osa.install_defaults
         defaults_from: "{{ install_method }}"
         public: true
+        apply:
+          tags:
+            - always
+      tags:
+        - always
 
     - name: Gather memory facts
       include_tasks: "common-tasks/gather-hardware-facts.yml"
@@ -200,6 +210,11 @@
         name: openstack.osa.install_defaults
         defaults_from: "{{ install_method }}"
         public: true
+        apply:
+          tags:
+            - always
+      tags:
+        - always
 
     - name: Gather memory facts
       include_tasks: "common-tasks/gather-hardware-facts.yml"

playbooks/ceph-nfs-install.yml

@@ -29,6 +29,11 @@
         name: openstack.osa.install_defaults
         defaults_from: "{{ install_method }}"
         public: true
+        apply:
+          tags:
+            - always
+      tags:
+        - always
 
     - name: Gather ceph-mon facts
       action: setup

playbooks/ceph-rgw-install.yml

@@ -33,6 +33,11 @@
         name: openstack.osa.install_defaults
         defaults_from: "{{ install_method }}"
         public: true
+        apply:
+          tags:
+            - always
+      tags:
+        - always
 
     - name: Importing ceph-server tasks
       import_tasks: common-tasks/ceph-server.yml

playbooks/ceph-rgw-keystone-setup.yml

@@ -30,6 +30,8 @@
       import_role:
         name: openstack.osa.install_defaults
         defaults_from: "{{ install_method | default('source') }}"
+      tags:
+        - always
 
     - name: Add service to the keystone service catalog
       openstack.cloud.catalog_service:

playbooks/common-playbooks/cinder.yml

@@ -25,6 +25,11 @@
         name: openstack.osa.install_defaults
         defaults_from: "{{ install_method }}"
         public: true
+        apply:
+          tags:
+            - always
+      tags:
+        - always
 
     # In order to ensure that any container, software or
     # config file changes which causes a container/service

playbooks/common-playbooks/neutron.yml

@@ -25,6 +25,11 @@
         name: openstack.osa.install_defaults
         defaults_from: "{{ install_method }}"
         public: true
+        apply:
+          tags:
+            - always
+      tags:
+        - always
 
     # In order to ensure that any container, software or
     # config file changes which causes a container/service

playbooks/containers-lxc-create.yml

@@ -22,6 +22,11 @@
         name: openstack.osa.install_defaults
         defaults_from: "{{ install_method }}"
         public: true
+        apply:
+          tags:
+            - always
+      tags:
+        - always
 
     - name: Add hosts to dynamic inventory group
       group_by:
@@ -52,6 +57,11 @@
         name: openstack.osa.install_defaults
         defaults_from: "{{ install_method }}"
         public: true
+        apply:
+          tags:
+            - always
+      tags:
+        - always
   roles:
     - role: "lxc_container_create"
   post_tasks:
@@ -84,6 +94,11 @@
         name: openstack.osa.install_defaults
         defaults_from: "{{ install_method }}"
         public: true
+        apply:
+          tags:
+            - always
+      tags:
+        - always
   roles:
     - role: "openstack_hosts"
       is_container: true

playbooks/openstack-hosts-setup.yml

@@ -55,6 +55,11 @@
         name: openstack.osa.install_defaults
         defaults_from: "{{ install_method }}"
         public: true
+        apply:
+          tags:
+            - always
+      tags:
+        - always
 
     - name: Check for a supported Operating System
       assert:

playbooks/openstack-resources.yml

@@ -21,6 +21,11 @@
         name: openstack.osa.install_defaults
         defaults_from: "{{ install_method }}"
         public: true
+        apply:
+          tags:
+            - always
+      tags:
+        - always
 
     - name: Include openstack_resources role
       ansible.builtin.include_role:

playbooks/os-adjutant-install.yml

@@ -44,6 +44,11 @@
         name: openstack.osa.install_defaults
         defaults_from: "{{ install_method }}"
         public: true
+        apply:
+          tags:
+            - always
+      tags:
+        - always
     # In order to ensure that any container, software or
     # config file changes which causes a container/service
     # restart do not cause an unexpected outage, we drain

playbooks/os-aodh-install.yml

@@ -48,6 +48,11 @@
         name: openstack.osa.install_defaults
         defaults_from: "{{ install_method }}"
         public: true
+        apply:
+          tags:
+            - always
+      tags:
+        - always
 
     - name: Disabling haproxy backends
       include_role:

playbooks/os-barbican-install.yml

@@ -44,6 +44,11 @@
         name: openstack.osa.install_defaults
         defaults_from: "{{ install_method }}"
         public: true
+        apply:
+          tags:
+            - always
+      tags:
+        - always
     # In order to ensure that any container, software or
     # config file changes which causes a container/service
     # restart do not cause an unexpected outage, we drain

playbooks/os-blazar-install.yml

@@ -44,6 +44,11 @@
         name: openstack.osa.install_defaults
         defaults_from: "{{ install_method }}"
         public: true
+        apply:
+          tags:
+            - always
+      tags:
+        - always
     # In order to ensure that any container, software or
     # config file changes which causes a container/service
     # restart do not cause an unexpected outage, we drain

playbooks/os-ceilometer-install.yml

@@ -34,6 +34,11 @@
         name: openstack.osa.install_defaults
         defaults_from: "{{ install_method }}"
         public: true
+        apply:
+          tags:
+            - always
+      tags:
+        - always
 
     - name: Including container-setup tasks
       include_role:

playbooks/os-cloudkitty-install.yml

@@ -45,6 +45,11 @@
         name: openstack.osa.install_defaults
         defaults_from: "{{ install_method }}"
         public: true
+        apply:
+          tags:
+            - always
+      tags:
+        - always
     # In order to ensure that any container, software or
     # config file changes which causes a container/service
     # restart do not cause an unexpected outage, we drain

playbooks/os-designate-install.yml

@@ -47,6 +47,11 @@
         name: openstack.osa.install_defaults
         defaults_from: "{{ install_method }}"
         public: true
+        apply:
+          tags:
+            - always
+      tags:
+        - always
     # In order to ensure that any container, software or
     # config file changes which causes a container/service
     # restart do not cause an unexpected outage, we drain

playbooks/os-glance-install.yml

@@ -44,6 +44,11 @@
         name: openstack.osa.install_defaults
         defaults_from: "{{ install_method }}"
         public: true
+        apply:
+          tags:
+            - always
+      tags:
+        - always
     # In order to ensure that any container, software or
     # config file changes which causes a container/service
     # restart do not cause an unexpected outage, we drain

playbooks/os-gnocchi-install.yml

@@ -44,6 +44,11 @@
         name: openstack.osa.install_defaults
         defaults_from: "{{ install_method }}"
         public: true
+        apply:
+          tags:
+            - always
+      tags:
+        - always
     # In order to ensure that any container, software or
     # config file changes which causes a container/service
     # restart do not cause an unexpected outage, we drain

playbooks/os-heat-install.yml

@@ -44,6 +44,11 @@
         name: openstack.osa.install_defaults
         defaults_from: "{{ install_method }}"
         public: true
+        apply:
+          tags:
+            - always
+      tags:
+        - always
     # In order to ensure that any container, software or
     # config file changes which causes a container/service
     # restart do not cause an unexpected outage, we drain

playbooks/os-horizon-install.yml

@@ -44,6 +44,11 @@
         name: openstack.osa.install_defaults
         defaults_from: "{{ install_method }}"
         public: true
+        apply:
+          tags:
+            - always
+      tags:
+        - always
     # In order to ensure that any container, software or
     # config file changes which causes a container/service
     # restart do not cause an unexpected outage, we drain

playbooks/os-ironic-install.yml

@@ -44,6 +44,11 @@
         name: openstack.osa.install_defaults
         defaults_from: "{{ install_method }}"
         public: true
+        apply:
+          tags:
+            - always
+      tags:
+        - always
     # In order to ensure that any container, software or
     # config file changes which causes a container/service
     # restart do not cause an unexpected outage, we drain

playbooks/os-keystone-install.yml

@@ -31,6 +31,11 @@
         name: openstack.osa.install_defaults
         defaults_from: "{{ install_method }}"
         public: true
+        apply:
+          tags:
+            - always
+      tags:
+        - always
   roles:
     - role: "openstack_openrc"
 
@@ -75,6 +80,11 @@
         name: openstack.osa.install_defaults
         defaults_from: "{{ install_method }}"
         public: true
+        apply:
+          tags:
+            - always
+      tags:
+        - always
 
     # In order to ensure that any container, software or
     # config file changes which causes a container/service
@@ -148,6 +158,11 @@
         name: openstack.osa.install_defaults
         defaults_from: "{{ install_method }}"
         public: true
+        apply:
+          tags:
+            - always
+      tags:
+        - always
 
     - name: Refresh local facts
       setup:

playbooks/os-magnum-install.yml

@@ -47,6 +47,11 @@
         name: openstack.osa.install_defaults
         defaults_from: "{{ install_method }}"
         public: true
+        apply:
+          tags:
+            - always
+      tags:
+        - always
     # In order to ensure that any container, software or
     # config file changes which causes a container/service
     # restart do not cause an unexpected outage, we drain

playbooks/os-manila-install.yml

@@ -43,6 +43,11 @@
         name: openstack.osa.install_defaults
         defaults_from: "{{ install_method }}"
         public: true
+        apply:
+          tags:
+            - always
+      tags:
+        - always
 
     - name: Gather additional facts
       include_tasks: "common-tasks/gather-hardware-facts.yml"

playbooks/os-masakari-install.yml

@@ -64,6 +64,11 @@
         name: openstack.osa.install_defaults
         defaults_from: "{{ install_method }}"
         public: true
+        apply:
+          tags:
+            - always
+      tags:
+        - always
 
     - name: Gather additional facts
       include_tasks: "common-tasks/gather-hardware-facts.yml"

playbooks/os-mistral-install.yml

@@ -44,6 +44,11 @@
         name: openstack.osa.install_defaults
         defaults_from: "{{ install_method }}"
         public: true
+        apply:
+          tags:
+            - always
+      tags:
+        - always
 
     # In order to ensure that any container, software or
     # config file changes which causes a container/service

playbooks/os-nova-install.yml

@@ -57,6 +57,11 @@
         name: openstack.osa.install_defaults
         defaults_from: "{{ install_method }}"
         public: true
+        apply:
+          tags:
+            - always
+      tags:
+        - always
 
     # Enable execution of ceph_client on the nova compute hosts if cinder RBD
     # backends are used. This is necessary to ensure that volume-backed Nova

playbooks/os-octavia-install.yml

@@ -44,6 +44,11 @@
         name: openstack.osa.install_defaults
         defaults_from: "{{ install_method }}"
         public: true
+        apply:
+          tags:
+            - always
+      tags:
+        - always
 
     # In order to ensure that any container, software or
     # config file changes which causes a container/service

playbooks/os-placement-install.yml

@@ -44,6 +44,11 @@
         name: openstack.osa.install_defaults
         defaults_from: "{{ install_method }}"
         public: true
+        apply:
+          tags:
+            - always
+      tags:
+        - always
 
     # In order to ensure that any container, software or
     # config file changes which causes a container/service

playbooks/os-rally-install.yml

@@ -30,6 +30,11 @@
         name: openstack.osa.install_defaults
         defaults_from: "{{ install_method }}"
         public: true
+        apply:
+          tags:
+            - always
+      tags:
+        - always
 
     - name: End playbook
       meta: end_play

playbooks/os-skyline-install.yml

@@ -44,6 +44,11 @@
         name: openstack.osa.install_defaults
         defaults_from: "{{ install_method }}"
         public: true
+        apply:
+          tags:
+            - always
+      tags:
+        - always
 
     - name: Including container-setup tasks
       include_role:

playbooks/os-swift-install.yml

@@ -42,6 +42,11 @@
         name: openstack.osa.install_defaults
         defaults_from: "{{ install_method }}"
         public: true
+        apply:
+          tags:
+            - always
+      tags:
+        - always
 
     - name: Including container-setup tasks
       include_role:

playbooks/os-swift-sync.yml

@@ -25,6 +25,11 @@
         name: openstack.osa.install_defaults
         defaults_from: "{{ install_method }}"
         public: true
+        apply:
+          tags:
+            - always
+      tags:
+        - always
   roles:
     - role: "os_swift"
       swift_do_setup: False

playbooks/os-tacker-install.yml

@@ -44,6 +44,11 @@
         name: openstack.osa.install_defaults
         defaults_from: "{{ install_method }}"
         public: true
+        apply:
+          tags:
+            - always
+      tags:
+        - always
 
     # In order to ensure that any container, software or
     # config file changes which causes a container/service

playbooks/os-tempest-install.yml

@@ -33,6 +33,11 @@
         name: openstack.osa.install_defaults
         defaults_from: "{{ install_method }}"
         public: true
+        apply:
+          tags:
+            - always
+      tags:
+        - always
 
     - name: End playbook
       meta: end_play

playbooks/os-trove-install.yml

@@ -47,6 +47,11 @@
         name: openstack.osa.install_defaults
         defaults_from: "{{ install_method }}"
         public: true
+        apply:
+          tags:
+            - always
+      tags:
+        - always
 
     # In order to ensure that any container, software or
     # config file changes which causes a container/service

playbooks/repo-install.yml

@@ -78,6 +78,11 @@
         name: openstack.osa.install_defaults
         defaults_from: "{{ install_method }}"
         public: true
+        apply:
+          tags:
+            - always
+      tags:
+        - always
   roles:
     - role: "repo_server"
   environment: "{{ deployment_environment_variables | default({}) }}"

playbooks/utility-install.yml

@@ -51,6 +51,11 @@
         name: openstack.osa.install_defaults
         defaults_from: "{{ install_method }}"
         public: true
+        apply:
+          tags:
+            - always
+      tags:
+        - always
 
     - name: Including container-setup tasks
       include_role: