From 21c24789019bf1ee85347356fe6c70b0b9045d7c Mon Sep 17 00:00:00 2001
From: Darren Birkett <darren.birkett@gmail.com>
Date: Thu, 5 May 2016 22:17:11 +0100
Subject: [PATCH] install rabbitmq-server in serial

In order to prevent race conditions with nodes joining the cluster
simultaneously when the cluster is first formed, we move the rabbitmq
installation play to be 'serial: 1'. However, when the nodes are being
upgraded, it cannot be done in serial so in this case we set 'serial: 0'

There are some tasks/roles called in this playbook that can still be
run in parallel, so we split out the rabbitmq-server install into a
separate play so that we only serialise the parts that are necessary
to ensure maximum efficiency.

Change-Id: I97cdae27fdce4f400492c2134b6589b55fbc5a61
Fixes-Bug: #1573030
---
 playbooks/rabbitmq-install.yml | 21 +++++++++++++++------
 1 file changed, 15 insertions(+), 6 deletions(-)

diff --git a/playbooks/rabbitmq-install.yml b/playbooks/rabbitmq-install.yml
index b74144e918..796728cefa 100644
--- a/playbooks/rabbitmq-install.yml
+++ b/playbooks/rabbitmq-install.yml
@@ -13,7 +13,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-- name: Install rabbitmq server
+- name: Create and configure rabbitmq container
   hosts: rabbitmq_all
   max_fail_percentage: 0
   user: root
@@ -44,6 +44,20 @@
   roles:
     - role: "pip_lock_down"
       when: "(groups['repo_all'] | length) >= 1"
+    - role: "system_crontab_coordination"
+      tags:
+        - "system-crontab-coordination"
+  vars:
+    is_metal: "{{ properties.is_metal|default(false) }}"
+
+# NOTE(mancdaz): rabbitmq cannot be upgraded in serial, so when
+# rabbitmq_upgrade=True, serial is set to 0, else it is 1 for installs
+- name: Install rabbitmq server
+  hosts: rabbitmq_all
+  serial: "{{ rabbitmq_upgrade|default(false) | bool | ternary(0, 1)}}"
+  max_fail_percentage: 20
+  user: root
+  roles:
     - role: "rabbitmq_server"
       tags:
         - "rabbitmq-server"
@@ -55,8 +69,3 @@
       tags:
         - "rabbitmq-rsyslog-client"
         - "rsyslog-client"
-    - role: "system_crontab_coordination"
-      tags:
-        - "system-crontab-coordination"
-  vars:
-    is_metal: "{{ properties.is_metal|default(false) }}"